restore original representation of `Tag` at the cost of some duplication

That way both representations are optimal in memory for their intended usecase. - `TagRef` is decodable from a buffer refers to it with all of its fields. That way round-trips are cheapest. - `Tag` does not allocate for hashes as there is a more compact representation: `git_hash::ObjectId`.

Sebastian Thiel committed 3 years ago

Commit dd0a23d1 parent 7242d1f6 files · +49 −59Browse files

Showing the changes to git-object/src/commit (1 of 6 files). Show all

Unified · Split

git-object/src/commit/write.rs+8−8

         out.write_all(&self.message)
     }
+    fn kind(&self) -> Kind {
+        Kind::Commit
+    }
     fn size(&self) -> usize {
         let hash_in_hex = self.tree.kind().len_in_hex();
         b"tree".len() + 1 /*space*/ + hash_in_hex + 1 /* nl */
             + 1 /* nl */
             + self.message.len()
     }
-    fn kind(&self) -> Kind {
-        Kind::Commit
-    }
 }
 impl<'a> crate::WriteTo for CommitRef<'a> {
         out.write_all(self.message)
     }
+    fn kind(&self) -> Kind {
+        Kind::Commit
+    }
     fn size(&self) -> usize {
         let hash_in_hex = self.tree().kind().len_in_hex();
         b"tree".len() + 1 /* space */ + hash_in_hex + 1 /* nl */
             + 1 /* nl */
             + self.message.len()
     }
-    fn kind(&self) -> Kind {
-        Kind::Commit
-    }
 }