[smart-release #155] don't set versions if the new ones match

Sebastian Thiel committed 5 years ago

Commit dd0f4281 parent 07dc6d81 file · +14 −9Browse files

Unified · Split

cargo-smart-release/src/command/release/manifest.rs+14−9

 };
 use cargo_metadata::{Metadata, Package};
 use git_repository::hash::ObjectId;
+use semver::{Version, VersionReq};
 use std::{collections::BTreeMap, str::FromStr};
 pub(in crate::command::release_impl) fn edit_version_and_fixup_dependent_crates(
     }
     for dep_type in &["dependencies", "dev-dependencies", "build-dependencies"] {
         for (name_to_find, new_version) in publishees.iter().map(|(p, nv)| (&p.name, nv)) {
+            let new_version = Version::parse(new_version)?;
             for name_to_find in package_to_update
                 .dependencies
                 .iter()
                     .and_then(|deps| deps.get_mut(name_to_find).and_then(|name| name.as_inline_table_mut()))
                     .and_then(|name_table| name_table.get_mut("version"))
                 {
-                    log::info!(
+                    let version_req = VersionReq::parse(&current_version.as_str().expect("versions are strings"))?;
-                        "Pending '{}' manifest {} update: '{} = \"{}\"' (from {})",
+                    if !version_req.matches(&new_version) {
-                        package_to_update.name,
+                        log::info!(
-                        dep_type,
+                            "Pending '{}' manifest {} update: '{} = \"{}\"' (from {})",
-                        name_to_find,
+                            package_to_update.name,
-                        new_version,
+                            dep_type,
-                        current_version
+                            name_to_find,
-                    );
+                            new_version,
-                    *current_version = toml_edit::Value::from(new_version.as_str());
+                            current_version
+                        );
+                        *current_version = toml_edit::Value::from(new_version.to_string().as_str());
+                    }
                 }
             }
         }