add test to check times before unix epoch

Sebastian Thiel committed 4 years ago

Commit eb304ea1 parent e1a14062 files · +20 −2Browse files

Unified · Split

2 files

 #[derive(thiserror::Error, Debug)]
 #[allow(missing_docs)]
 pub enum Error {
+    #[error("Cannot represent times before UNIX epoch at timestamp {timestamp}")]
+    TooEarly { timestamp: i64 },
     #[error("Date string can not be parsed")]
     InvalidDateString,
     #[error("Dates past 2038 can not be represented.")]
             // Format::Raw
             val
         } else if let Some(time) = relative::parse(input, now).transpose()? {
-            Time::new(time.unix_timestamp().try_into()?, time.offset().whole_seconds())
+            Time::new(timestamp(time)?, time.offset().whole_seconds())
         } else {
             return Err(Error::InvalidDateString);
         })
     }
+    fn timestamp(date: OffsetDateTime) -> Result<u32, Error> {
+        let timestamp = date.unix_timestamp();
+        if timestamp < 0 {
+            Err(Error::TooEarly { timestamp })
+        } else {
+            Ok(timestamp.try_into()?)
+        }
+    }
     fn parse_raw(input: &str) -> Option<Time> {
         let mut split = input.split_whitespace();
         let seconds_since_unix_epoch: u32 = split.next()?.parse().ok()?;

 }
 mod relative {
+    use git_date::parse::Error;
     use git_date::time::Sign;
     use std::time::SystemTime;
     use time::{Duration, OffsetDateTime};
     #[test]
     #[should_panic] // TODO: fix
-    fn large_ffsets_can_panic_elsewhere() {
+    fn large_offsets_can_panic_elsewhere() {
         git_date::parse("9999999999 weeks ago", Some(std::time::UNIX_EPOCH)).ok();
     }
+    #[test]
+    fn offset_leading_to_before_unix_epoch_cannot_be_represented() {
+        let err = git_date::parse("1 second ago", Some(std::time::UNIX_EPOCH)).unwrap_err();
+        assert!(matches!(err, Error::TooEarly{timestamp} if timestamp == -1));
+    }
     #[test]
     fn various() {
         let now = Some(SystemTime::now());