fix: file:// command invocation won't spill stderr output.

This usually doesn't add any benefit to the user as we might see events like the git process' failure to flush to a closed channel even though this is entirely handled by the Rust side of things. I can imagine that one day this might become a configurable to help with debugging to help making better-behaved clients, but maybe it won't ever matter once the default file:// transport is built-in and native.

Sebastian Thiel committed 3 years ago

Commit ec2f2e31 parent 5ac9fbe1 file · +1 −1Browse files

Unified · Split

git-transport/src/client/blocking_io/file.rs+1−1

@@ -190,7 +190,7 @@ impl client::Transport for SpawnProcessOnDemand { · 189 unmodified lines
190	Cow::Owned(command.to_owned()),	190	Cow::Owned(command.to_owned()),
191	),	191	),
192	None => (	192	None => (
193	git_command::prepare(service.as_str()),	193	git_command::prepare(service.as_str()).stderr(Stdio::null()),
194	None,	194	None,
195	Cow::Borrowed(OsStr::new(service.as_str())),	195	Cow::Borrowed(OsStr::new(service.as_str())),
196	),	196	),