History

assure changelog picks up safety bumps as well (#222)

Sebastian Thiel committed 5 years ago

Commit f2a497b1 parent 7496ba32 files · +14 −2Browse files

Unified · Split

2 files
  1. cargo-smart-release/src/command/changelog.rs +1 −2
  2. cargo-smart-release/src/traverse.rs +13 −0
cargo-smart-release/src/command/changelog.rs+1−2
@@ -5,7 +5,6 @@ use crate::{ · 4 unmodified lines
55 changelog::write::{Components, Linkables},
66 command::changelog::Options,
77 git,
8− traverse::dependency,
98 utils::{package_by_name, will},
109 version::BumpSpec,
1110 ChangeLog,
@@ -28,7 +27,7 @@ pub fn changelog(opts: Options, crates: Vec<String>) -> anyhow::Result<()> { · 16 unmodified lines
2827 let bump_only_when_needed = true;
2928 crate::traverse::dependencies(&ctx, add_production_crates, bump_only_when_needed)?
3029 .into_iter()
31− .filter_map(|d| matches!(d.mode, dependency::Mode::ToBePublished { .. }).then(|| d.package))
30+ .filter_map(|d| d.mode.has_version_adjustment().then(|| d.package))
3231 .collect()
3332 } else {
3433 ctx.crate_names
cargo-smart-release/src/traverse.rs+13−0
@@ -56,6 +56,19 @@ pub mod dependency { · 55 unmodified lines
5656 /// One of our dependencies will see a version adjustment, which we must update in our manifest
5757 ManifestNeedsUpdate,
5858 }
59+
60+ impl<'meta> Mode<'meta> {
61+ pub fn has_version_adjustment(&self) -> bool {
62+ matches!(
63+ self,
64+ Mode::ToBePublished { .. }
65+ | Mode::Skipped {
66+ adjustment: Some(_),
67+ ..
68+ }
69+ )
70+ }
71+ }
5972 }
6073
6174 #[derive(Debug)]