It was not clear if users should activate both sets of completions if they wanted the dynamic ones. The shell commands for activating the dynamic completions are aligned with the static version. Users can choose / are responsible themselves to add the activation to their shell config if they want them in every shell instance. For fish specifically, `script | source` is more idiomatic than `source (script | psub)`.
Unified · Split
| @@ -210,12 +210,13 @@ To set up command-line completion, source the output of · 209 unmodified lines | ||
| 210 | 210 | `jj util completion bash/zsh/fish`. Exactly how to source it |
| 211 | 211 | depends on your shell. |
| 212 | 212 | |
| 213 | −Improved completions are currently in the works, these will complete things | |
| 214 | −like bookmark names as well. You can activate them with the alternative "dynamic" | |
| 215 | −instructions below. Please let us know if you encounter any issues, so we can | |
| 216 | −ensure a smooth transition once we default to these new completions. If you | |
| 217 | −have ideas about specific completions that could be added, please share them | |
| 218 | −[here](https://github.com/martinvonz/jj/issues/4763). | |
| 213 | +Improved completions are currently in the works, these will complete things like | |
| 214 | +bookmark names as well. You can activate them with the alternative "dynamic" | |
| 215 | +instructions below. They should still complete everything the static completions | |
| 216 | +did, so only activate one of them. Please let us know if you encounter any | |
| 217 | +issues, so we can ensure a smooth transition once we default to these new | |
| 218 | +completions. If you have ideas about specific completions that could be added, | |
| 219 | +please share them [here](https://github.com/martinvonz/jj/issues/4763). | |
| 219 | 220 | |
| 220 | 221 | ### Bash |
| 221 | 222 | |
| @@ -226,7 +227,7 @@ source <(jj util completion bash) · 4 unmodified lines | ||
| 226 | 227 | dynamic: |
| 227 | 228 | |
| 228 | 229 | ```shell |
| 229 | −echo "source <(COMPLETE=bash jj)" >> ~/.bashrc | |
| 230 | +source <(COMPLETE=bash jj) | |
| 230 | 231 | ``` |
| 231 | 232 | |
| 232 | 233 | ### Zsh |
| @@ -240,7 +241,7 @@ source <(jj util completion zsh) · 7 unmodified lines | ||
| 240 | 241 | dynamic: |
| 241 | 242 | |
| 242 | 243 | ```shell |
| 243 | −echo "source <(COMPLETE=zsh jj)" >> ~/.zshrc | |
| 244 | +source <(COMPLETE=zsh jj) | |
| 244 | 245 | ``` |
| 245 | 246 | |
| 246 | 247 | ### Fish |
| @@ -252,7 +253,7 @@ jj util completion fish | source · 5 unmodified lines | ||
| 252 | 253 | dynamic: |
| 253 | 254 | |
| 254 | 255 | ```shell |
| 255 | −echo "source (COMPLETE=fish jj | psub)" >> ~/.config/fish/config.fish | |
| 256 | +COMPLETE=fish jj | source | |
| 256 | 257 | ``` |
| 257 | 258 | |
| 258 | 259 | ### Nushell |