With the bridge no longer calling switchdev_port_attr_get() to obtain the supported bridge port flags from a driver but instead trying to set the bridge port flags directly and relying on driver to reject unsupported configurations, we can effectively get rid of switchdev_port_attr_get() entirely since this was the only place where it was called.
Showing the changes to include/net/switchdev.h (1 of 6 files). Show all
Unified · Split
| @@ -179,8 +179,6 @@ switchdev_notifier_info_to_extack(const struct switchdev_notifier_info *info) · 178 unmodified lines | |||
| 179 | #ifdef CONFIG_NET_SWITCHDEV | 179 | #ifdef CONFIG_NET_SWITCHDEV |
| 180 | 180 | ||
| 181 | void switchdev_deferred_process(void); | 181 | void switchdev_deferred_process(void); |
| 182 | int switchdev_port_attr_get(struct net_device *dev, | ||
| 183 | struct switchdev_attr *attr); | ||
| 184 | int switchdev_port_attr_set(struct net_device *dev, | 182 | int switchdev_port_attr_set(struct net_device *dev, |
| 185 | const struct switchdev_attr *attr); | 183 | const struct switchdev_attr *attr); |
| 186 | int switchdev_port_obj_add(struct net_device *dev, | 184 | int switchdev_port_obj_add(struct net_device *dev, |
| @@ -225,12 +223,6 @@ static inline void switchdev_deferred_process(void) · 38 unmodified lines | |||
| 225 | { | 223 | { |
| 226 | } | 224 | } |
| 227 | 225 | ||
| 228 | static inline int switchdev_port_attr_get(struct net_device *dev, | ||
| 229 | struct switchdev_attr *attr) | ||
| 230 | { | ||
| 231 | return -EOPNOTSUPP; | ||
| 232 | } | ||
| 233 | |||
| 234 | static inline int switchdev_port_attr_set(struct net_device *dev, | 226 | static inline int switchdev_port_attr_set(struct net_device *dev, |
| 235 | const struct switchdev_attr *attr) | 227 | const struct switchdev_attr *attr) |
| 236 | { | 228 | { |