If the clipped dirty region's x/y happened to align to 256, we would have set the top 8 bits wrong. Noticed by inspection, not by reproducing a bug.
Unified · Split
| @@ -240,10 +240,10 @@ static int mipi_dbi_fb_dirty(struct drm_framebuffer *fb, · 239 unmodified lines | ||
| 240 | 240 | |
| 241 | 241 | mipi_dbi_command(mipi, MIPI_DCS_SET_COLUMN_ADDRESS, |
| 242 | 242 | (clip.x1 >> 8) & 0xFF, clip.x1 & 0xFF, |
| 243 | − (clip.x2 >> 8) & 0xFF, (clip.x2 - 1) & 0xFF); | |
| 243 | + ((clip.x2 - 1) >> 8) & 0xFF, (clip.x2 - 1) & 0xFF); | |
| 244 | 244 | mipi_dbi_command(mipi, MIPI_DCS_SET_PAGE_ADDRESS, |
| 245 | 245 | (clip.y1 >> 8) & 0xFF, clip.y1 & 0xFF, |
| 246 | − (clip.y2 >> 8) & 0xFF, (clip.y2 - 1) & 0xFF); | |
| 246 | + ((clip.y2 - 1) >> 8) & 0xFF, (clip.y2 - 1) & 0xFF); | |
| 247 | 247 | |
| 248 | 248 | ret = mipi_dbi_command_buf(mipi, MIPI_DCS_WRITE_MEMORY_START, tr, |
| 249 | 249 | (clip.x2 - clip.x1) * (clip.y2 - clip.y1) * 2); |