err is being checked for failure each time it is being updated so this err check is totally redundant and can be removed Detected with CoverityScan, CID#1420665 ("Logically dead code")
Unified · Split
| @@ -2654,9 +2654,6 @@ static int sony_input_configured(struct hid_device *hdev, · 2653 unmodified lines | ||
| 2654 | 2654 | ret = 0; |
| 2655 | 2655 | } |
| 2656 | 2656 | |
| 2657 | − if (ret < 0) | |
| 2658 | − goto err_stop; | |
| 2659 | − | |
| 2660 | 2657 | if (sc->quirks & SONY_LED_SUPPORT) { |
| 2661 | 2658 | ret = sony_leds_init(sc); |
| 2662 | 2659 | if (ret < 0) |