History

kcmp: add KCMP_EPOLL_TFD mode to compare epoll target files

With current epoll architecture target files are addressed with file_struct and file descriptor number, where the last is not unique. Moreover files can be transferred from another process via unix socket, added into queue and closed then so we won't find this descriptor in the task fdinfo list. Thus to checkpoint and restore such processes CRIU needs to find out where exactly the target file is present to add it into epoll queue. For this sake one can use kcmp call where some particular target file from the queue is compared with arbitrary file passed as an argument. Because epoll target files can have same file descriptor number but different file_struct a caller should explicitly specify the offset within. To test if some particular file is matching entry inside epoll one have to - fill kcmp_epoll_slot structure with epoll file descriptor, target file number and target file offset (in case if only one target is present then it should be 0) - call kcmp as kcmp(pid1, pid2, KCMP_EPOLL_TFD, fd, &kcmp_epoll_slot) - the kernel fetch file pointer matching file descriptor @fd of pid1 - lookups for file struct in epoll queue of pid2 and returns traditional 0,1,2 result for sorting purpose

Cyrill Gorcunov committed 9 years ago

Commit 0791e361 parent 77493f04 files · +112 −0Browse files

Showing the changes to include/uapi/linux (1 of 4 files). Show all

Unified · Split

include/uapi/linux/kcmp.h+10−0
@@ -1,6 +1,8 @@
1#ifndef _UAPI_LINUX_KCMP_H1#ifndef _UAPI_LINUX_KCMP_H
2#define _UAPI_LINUX_KCMP_H2#define _UAPI_LINUX_KCMP_H
3 3
4#include <linux/types.h>
5
4/* Comparison type */6/* Comparison type */
5enum kcmp_type {7enum kcmp_type {
6 KCMP_FILE,8 KCMP_FILE,
@@ -10,8 +12,16 @@ enum kcmp_type { · 3 unmodified lines
10 KCMP_SIGHAND,12 KCMP_SIGHAND,
11 KCMP_IO,13 KCMP_IO,
12 KCMP_SYSVSEM,14 KCMP_SYSVSEM,
15 KCMP_EPOLL_TFD,
13 16
14 KCMP_TYPES,17 KCMP_TYPES,
15};18};
16 19
20/* Slot for KCMP_EPOLL_TFD */
21struct kcmp_epoll_slot {
22 __u32 efd; /* epoll file descriptor */
23 __u32 tfd; /* target file number */
24 __u32 toff; /* target offset within same numbered sequence */
25};
26
17#endif /* _UAPI_LINUX_KCMP_H */27#endif /* _UAPI_LINUX_KCMP_H */