History

blktrace: Show requests without sector

Currently, blktrace will not show requests that don't have any data as rq->__sector is initialized to -1 which is out of device range and thus discarded by act_log_check(). This is most notably the case for cache flush requests sent to the device. Fix the problem by making blk_rq_trace_sector() return 0 for requests without initialized sector.

Jan Kara committed 7 years ago

Commit 0803de71 parent 43636c81 file · +7 −1Browse files

Unified · Split

include/linux/blktrace_api.h+7−1
@@ -116,7 +116,13 @@ extern void blk_fill_rwbs(char *rwbs, unsigned int op, int bytes); · 115 unmodified lines
116116
117117 static inline sector_t blk_rq_trace_sector(struct request *rq)
118118 {
119− return blk_rq_is_passthrough(rq) ? 0 : blk_rq_pos(rq);
119+ /*
120+ * Tracing should ignore starting sector for passthrough requests and
121+ * requests where starting sector didn't get set.
122+ */
123+ if (blk_rq_is_passthrough(rq) || blk_rq_pos(rq) == (sector_t)-1)
124+ return 0;
125+ return blk_rq_pos(rq);
120126 }
121127
122128 static inline unsigned int blk_rq_trace_nr_sectors(struct request *rq)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t