->size in struct qaic_attach_slice_hdr is redundant since we have BO handle and its size can be retrieved from base BO structure.
Showing the changes to include/uapi (1 of 2 files). Show all
Unified · Split
| @@ -242,18 +242,7 @@ struct qaic_attach_slice_entry { · 241 unmodified lines | |||
| 242 | * @dbc_id: In. Associate the sliced BO with this DBC. | 242 | * @dbc_id: In. Associate the sliced BO with this DBC. |
| 243 | * @handle: In. GEM handle of the BO to slice. | 243 | * @handle: In. GEM handle of the BO to slice. |
| 244 | * @dir: In. Direction of data flow. 1 = DMA_TO_DEVICE, 2 = DMA_FROM_DEVICE | 244 | * @dir: In. Direction of data flow. 1 = DMA_TO_DEVICE, 2 = DMA_FROM_DEVICE |
| 245 | * @size: In. Total length of BO being used. This should not exceed base | 245 | * @size: Deprecated. This value is ignored and size of @handle is used instead. |
| 246 | * size of BO (struct drm_gem_object.base) | ||
| 247 | * For BOs being allocated using DRM_IOCTL_QAIC_CREATE_BO, size of | ||
| 248 | * BO requested is PAGE_SIZE aligned then allocated hence allocated | ||
| 249 | * BO size maybe bigger. This size should not exceed the new | ||
| 250 | * PAGE_SIZE aligned BO size. | ||
| 251 | * @dev_addr: In. Device address this slice pushes to or pulls from. | ||
| 252 | * @db_addr: In. Address of the doorbell to ring. | ||
| 253 | * @db_data: In. Data to write to the doorbell. | ||
| 254 | * @db_len: In. Size of the doorbell data in bits - 32, 16, or 8. 0 is for | ||
| 255 | * inactive doorbells. | ||
| 256 | * @offset: In. Start of this slice as an offset from the start of the BO. | ||
| 257 | */ | 246 | */ |
| 258 | struct qaic_attach_slice_hdr { | 247 | struct qaic_attach_slice_hdr { |
| 259 | __u32 count; | 248 | __u32 count; |