History

Input: alps - do not reduce trackpoint speed by half

On some v7 devices (e.g. Lenovo-E550) the deltas reported are typically only in the 0-1 range dividing this by 2 results in a range of 0-0. And even for v7 devices where this does not lead to making the trackstick entirely unusable, it makes it twice as slow as before we added v7 support and were using the ps/2 mouse emulation of the dual point setup. If some kind of generic slowdown is actually necessary for some devices, then that belongs in userspace, not in the kernel.

Hans de Goede committed 11 years ago

Commit 088df2c1 parent 692dd191 file · +2 −3Browse files

Unified · Split

drivers/input/mouse/alps.c+2−3
@@ -1063,9 +1063,8 @@ static void alps_process_trackstick_packet_v7(struct psmouse *psmouse) · 1062 unmodified lines
10631063 right = (packet[1] & 0x02) >> 1;
10641064 middle = (packet[1] & 0x04) >> 2;
10651065
1066− /* Divide 2 since trackpoint's speed is too fast */
1067− input_report_rel(dev2, REL_X, (char)x / 2);
1068− input_report_rel(dev2, REL_Y, -((char)y / 2));
1066+ input_report_rel(dev2, REL_X, (char)x);
1067+ input_report_rel(dev2, REL_Y, -((char)y));
10691068
10701069 input_report_key(dev2, BTN_LEFT, left);
10711070 input_report_key(dev2, BTN_RIGHT, right);