reparent_leader: check EXIT_DEAD instead of task_detached()

Change reparent_leader() to check ->exit_state instead of ->exit_signal, this matches the similar EXIT_DEAD check in wait_consider_task() and allows us to cleanup the do_notify_parent/task_detached logic. task_detached() was really needed during reparenting before 9cd80bbb "do_wait() optimization: do not place sub-threads on ->children list" to filter out the sub-threads. After this change task_detached(p) can only be true if p is the dead group_leader and its parent ignores SIGCHLD, in this case the caller of do_notify_parent() is going to reap this task and it should set EXIT_DEAD.

Oleg Nesterov committed 15 years ago

Commit 0976a031 parent 86773471 file · +1 −1Browse files

Unified · Split

kernel/exit.c+1−1

@@ -742,7 +742,7 @@ static void reparent_leader(struct task_struct father, struct task_struct p, · 741 unmodified lines
742	{	742	{
743	list_move_tail(&p->sibling, &p->real_parent->children);	743	list_move_tail(&p->sibling, &p->real_parent->children);
744		744
745	if (task_detached(p))	745	if (p->exit_state == EXIT_DEAD)
746	return;	746	return;
747	/*	747	/*
748	* If this is a threaded reparent there is no need to	748	* If this is a threaded reparent there is no need to