History

timer: Fix bad idle check on irq entry

idle_cpu() is called on irq entry to guess if we need to call tick_check_idle(). This way we can catch up with jiffies if the tick was stopped, stop accounting idle time during the interrupt and maintain the sched clock if it is unstable. But if we are going to exit the idle loop to schedule a new task (ie: if we have a task in the runqueue or a remotely enqueued ttwu to perform), the idle_cpu() check will return 0 such that we miss the call to tick_check_idle() for all interrupts happening before we schedule the new task. As a result these interrupts and the softirqs coming along may deal with stale jiffies values, bad sched clock values, and won't substract their time from the idle time accounting. Fix this with using is_idle_task() instead that strictly checks that we are running the idle task, without caring about the fact we are going to schedule a task soon.

Frederic Weisbecker committed 14 years ago

Commit 0a8a2e71 parent 15f827b1 file · +1 −1Browse files

Unified · Split

kernel/softirq.c+1−1
@@ -297,7 +297,7 @@ void irq_enter(void) · 296 unmodified lines
297297 int cpu = smp_processor_id();
298298
299299 rcu_irq_enter();
300− if (idle_cpu(cpu) && !in_interrupt()) {
300+ if (is_idle_task(current) && !in_interrupt()) {
301301 /*
302302 * Prevent raise_softirq from needlessly waking up ksoftirqd
303303 * here, as softirq will be serviced on return from interrupt.

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t