History

kbuild: call make once for all targets when O=.. is used

Change the invocations of make in the output directory Makefile and the main Makefile for separate object trees to pass all goals to one $(MAKE) via a new phony target "sub-make" and the existing target _all. When compiling with separate object directories, a separate make is called in the context of another directory (from the output directory the main Makefile is called, the Makefile is then restarted with current directory set to the object tree). Before this patch, when multiple make command goals are specified, each target results in a separate make invocation. With make -j, these invocations may run in parallel, resulting in multiple commands running in the same directory clobbering each others results. I did not try to address make -j for mixed dot-config and no-dot-config targets. Because the order does matter, a solution was not obvious. Perhaps a simple check for MAKEFLAGS having -j and refusing to run would be appropriate.

Milton Miller committed 19 years ago

Commit 0b357861 parent cf851aa2 files · +13 −6Browse files

Showing the changes to scripts (1 of 2 files). Show all

Unified · Split

scripts/mkmakefile+5−3
@@ -26,11 +26,13 @@ MAKEFLAGS += --no-print-directory · 25 unmodified lines
26 26
27.PHONY: all \$(MAKECMDGOALS)27.PHONY: all \$(MAKECMDGOALS)
28 28
29all := \$(filter-out all Makefile,\$(MAKECMDGOALS))
30
29all:31all:
30 \$(MAKE) -C \$(KERNELSRC) O=\$(KERNELOUTPUT)32 \$(MAKE) -C \$(KERNELSRC) O=\$(KERNELOUTPUT) \$(all)
31 33
32Makefile:;34Makefile:;
33 35
34\$(filter-out all Makefile,\$(MAKECMDGOALS)) %/:36\$(all) %/: all
35 \$(MAKE) -C \$(KERNELSRC) O=\$(KERNELOUTPUT) \$@37 @:
36EOF38EOF

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t