History

powerpc/ps3: Fix map failure path in dma_ioc0_map_pages()

If lv1_put_iopte() fails in dma_ioc0_map_pages(), the error path decrements iopage but keeps using the failed mapping's offset. As a result, it repeatedly tries to invalidate the failed IOPTE slot and leaves the already installed IOPTEs valid. Recompute offset and invalidate the installed IOPTEs instead.

Thorsten Blum committed 4 months ago

Commit 0bb024f1 parent 41bf83c1 file · +1 −0Browse files

Unified · Split

arch/powerpc/platforms/ps3/mm.c+1−0
@@ -615,6 +615,7 @@ static int dma_ioc0_map_pages(struct ps3_dma_region *r, unsigned long phys_addr, · 614 unmodified lines
615 615
616fail_map:616fail_map:
617 for (iopage--; 0 <= iopage; iopage--) {617 for (iopage--; 0 <= iopage; iopage--) {
618 offset = (1 << r->page_size) * iopage;
618 lv1_put_iopte(0,619 lv1_put_iopte(0,
619 c->bus_addr + offset,620 c->bus_addr + offset,
620 c->lpar_addr + offset,621 c->lpar_addr + offset,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t