Currently, FunctionFS exposes each USB endpoint as a separate, unidirectional file descriptor (e.g., `ep1` for IN, `ep2` for OUT). While this mirrors the underlying hardware structure, it forces userspace daemons implementing bidirectional protocols to manage multiple file descriptors. When dealing with legacy protocols which require exposing a single, bi-directional fd to userspace, this becomes problematic. This patch introduces the `FUNCTIONFS_RW_PROXY_EPS` UAPI flag. When passed in the descriptor header during initialization, FunctionFS provisions a "rw_proxy" bidirectional file descriptor (e.g., `ep1_rw`) alongside every pair of IN/OUT endpoints. Implementation details: - RW proxy files act as a pure VFS alias, proxying operations directly to the base ffs_epfile instances. A `read()` proxies to the OUT endpoint's file, and a `write()` proxies to the IN file. - Because operations are proxied natively, they reuse the underlying base endpoint's lock (`epfile->mutex`) and tracking state. This serializes concurrent I/O, preventing buffer corruption or races even if userspace mixes transfers across both the rw_proxy and base files while allowing full-duplex synchronous operations to occur concurrently without serializing on a single lock. - Control operations (like IOCTLs) and intentional stalls (via reverse-direction I/O) must still be issued on the base endpoints, as the rw_proxy returns `-ENOTTY` for IOCTLs and cannot trigger stalls.
Showing the changes to include/uapi (1 of 4 files). Show all
Unified · Split
| @@ -25,6 +25,7 @@ enum functionfs_flags { · 24 unmodified lines | ||
| 25 | 25 | FUNCTIONFS_EVENTFD = 32, |
| 26 | 26 | FUNCTIONFS_ALL_CTRL_RECIP = 64, |
| 27 | 27 | FUNCTIONFS_CONFIG0_SETUP = 128, |
| 28 | + FUNCTIONFS_RW_PROXY_EPS = 256, | |
| 28 | 29 | }; |
| 29 | 30 | |
| 30 | 31 | /* Descriptor of an non-audio endpoint */ |