This change restricts the check for the for the FSF address in the GPL copyright statement so that it only flags the address, not the references to the gnu.org/licenses URL which appears to be used in numerous drivers. The idea is to still allow some reference to an external copy of the GPL in the event that files are copied out of the kernel tree without the COPYING file. So for example this statement will still return an error: You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. However, this statement will not return an error after this patch: You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>.
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -1970,14 +1970,12 @@ sub process { · 1969 unmodified lines | |||
| 1970 | } | 1970 | } |
| 1971 | 1971 | ||
| 1972 | # Check for FSF mailing addresses. | 1972 | # Check for FSF mailing addresses. |
| 1973 | if ($rawline =~ /\bYou should have received a copy/i || | 1973 | if ($rawline =~ /\bwrite to the Free/i || |
| 1974 | $rawline =~ /\bwrite to the Free/i || | ||
| 1975 | $rawline =~ /\b59\s+Temple\s+Pl/i || | 1974 | $rawline =~ /\b59\s+Temple\s+Pl/i || |
| 1976 | $rawline =~ /\b51\s+Franklin\s+St/i) { | 1975 | $rawline =~ /\b51\s+Franklin\s+St/i) { |
| 1977 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; | 1976 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
| 1978 | my $msg_type = \&ERROR; | 1977 | my $msg_type = \&ERROR; |
| 1979 | $msg_type = \&CHK if ($file); | 1978 | $msg_type = \&CHK if ($file); |
| 1980 | $msg_type = \&CHK if ($rawline =~ /\bYou should have received a copy/i); | ||
| 1981 | &{$msg_type}("FSF_MAILING_ADDRESS", | 1979 | &{$msg_type}("FSF_MAILING_ADDRESS", |
| 1982 | "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) | 1980 | "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) |
| 1983 | } | 1981 | } |