History

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid

Pull HID updates from Jiri Kosina: "This time it's surprisingly quiet (probably due to the christmas break): - Logitech HID++ protocol improvements from Mazin Rezk, Pedro Vanzella and Adrian Freund - support for hidraw uniq ioctl from Marcel Holtmann" * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid: HID: logitech-hidpp: avoid duplicate error handling code in 'hidpp_probe()' hid-logitech-hidpp: read battery voltage from newer devices HID: logitech: Add MX Master 3 Mouse HID: logitech-hidpp: Support WirelessDeviceStatus connect events HID: logitech-hidpp: Support translations from short to long reports HID: hidraw: add support uniq ioctl

Linus Torvalds committed 6 years ago

Commit 12fb2b92 parents 08c49dc fef684a3 files · +242 −15Browse files

Unified · Split

3 files
  1. drivers/hid/hid-logitech-hidpp.c +232 −15
  2. drivers/hid/hidraw.c +9 −0
  3. include/uapi/linux/hidraw.h +1 −0
drivers/hid/hid-logitech-hidpp.c+232−15
@@ -49,6 +49,10 @@ MODULE_PARM_DESC(disable_tap_to_click, · 48 unmodified lines
4949 #define HIDPP_REPORT_LONG_LENGTH 20
5050 #define HIDPP_REPORT_VERY_LONG_MAX_LENGTH 64
5151
52+#define HIDPP_REPORT_SHORT_SUPPORTED BIT(0)
53+#define HIDPP_REPORT_LONG_SUPPORTED BIT(1)
54+#define HIDPP_REPORT_VERY_LONG_SUPPORTED BIT(2)
55+
5256 #define HIDPP_SUB_ID_CONSUMER_VENDOR_KEYS 0x03
5357 #define HIDPP_SUB_ID_ROLLER 0x05
5458 #define HIDPP_SUB_ID_MOUSE_EXTRA_BTNS 0x06
@@ -87,6 +91,7 @@ MODULE_PARM_DESC(disable_tap_to_click, · 32 unmodified lines
8791 #define HIDPP_CAPABILITY_HIDPP20_BATTERY BIT(1)
8892 #define HIDPP_CAPABILITY_BATTERY_MILEAGE BIT(2)
8993 #define HIDPP_CAPABILITY_BATTERY_LEVEL_STATUS BIT(3)
94+#define HIDPP_CAPABILITY_BATTERY_VOLTAGE BIT(4)
9095
9196 /*
9297 * There are two hidpp protocols in use, the first version hidpp10 is known
@@ -135,12 +140,15 @@ struct hidpp_report { · 42 unmodified lines
135140 struct hidpp_battery {
136141 u8 feature_index;
137142 u8 solar_feature_index;
143+ u8 voltage_feature_index;
138144 struct power_supply_desc desc;
139145 struct power_supply *ps;
140146 char name[64];
141147 int status;
142148 int capacity;
143149 int level;
150+ int voltage;
151+ int charge_type;
144152 bool online;
145153 };
146154
@@ -183,9 +191,12 @@ struct hidpp_device { · 36 unmodified lines
183191
184192 unsigned long quirks;
185193 unsigned long capabilities;
194+ u8 supported_reports;
186195
187196 struct hidpp_battery battery;
188197 struct hidpp_scroll_counter vertical_wheel_counter;
198+
199+ u8 wireless_feature_index;
189200 };
190201
191202 /* HID++ 1.0 error codes */
@@ -340,6 +351,11 @@ static int hidpp_send_rap_command_sync(struct hidpp_device *hidpp_dev, · 148 unmodified lines
340351 struct hidpp_report *message;
341352 int ret, max_count;
342353
354+ /* Send as long report if short reports are not supported. */
355+ if (report_id == REPORT_ID_HIDPP_SHORT &&
356+ !(hidpp_dev->supported_reports & HIDPP_REPORT_SHORT_SUPPORTED))
357+ report_id = REPORT_ID_HIDPP_LONG;
358+
343359 switch (report_id) {
344360 case REPORT_ID_HIDPP_SHORT:
345361 max_count = HIDPP_REPORT_SHORT_LENGTH - 4;
@@ -393,10 +409,13 @@ static inline bool hidpp_match_error(struct hidpp_report *question, · 47 unmodified lines
393409 (answer->fap.params[0] == question->fap.funcindex_clientid);
394410 }
395411
396−static inline bool hidpp_report_is_connect_event(struct hidpp_report *report)
412+static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp,
413+ struct hidpp_report *report)
397414 {
398− return (report->report_id == REPORT_ID_HIDPP_SHORT) &&
399− (report->rap.sub_id == 0x41);
415+ return (hidpp->wireless_feature_index &&
416+ (report->fap.feature_index == hidpp->wireless_feature_index)) ||
417+ ((report->report_id == REPORT_ID_HIDPP_SHORT) &&
418+ (report->rap.sub_id == 0x41));
400419 }
401420
402421 /**
@@ -1222,6 +1241,144 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, · 819 unmodified lines
12221241 return 0;
12231242 }
12241243
1244+/* -------------------------------------------------------------------------- */
1245+/* 0x1001: Battery voltage */
1246+/* -------------------------------------------------------------------------- */
1247+
1248+#define HIDPP_PAGE_BATTERY_VOLTAGE 0x1001
1249+
1250+#define CMD_BATTERY_VOLTAGE_GET_BATTERY_VOLTAGE 0x00
1251+
1252+#define EVENT_BATTERY_VOLTAGE_STATUS_BROADCAST 0x00
1253+
1254+static int hidpp20_battery_map_status_voltage(u8 data[3], int *voltage,
1255+ int *level, int *charge_type)
1256+{
1257+ int status;
1258+
1259+ long charge_sts = (long)data[2];
1260+
1261+ *level = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN;
1262+ switch (data[2] & 0xe0) {
1263+ case 0x00:
1264+ status = POWER_SUPPLY_STATUS_CHARGING;
1265+ break;
1266+ case 0x20:
1267+ status = POWER_SUPPLY_STATUS_FULL;
1268+ *level = POWER_SUPPLY_CAPACITY_LEVEL_FULL;
1269+ break;
1270+ case 0x40:
1271+ status = POWER_SUPPLY_STATUS_DISCHARGING;
1272+ break;
1273+ case 0xe0:
1274+ status = POWER_SUPPLY_STATUS_NOT_CHARGING;
1275+ break;
1276+ default:
1277+ status = POWER_SUPPLY_STATUS_UNKNOWN;
1278+ }
1279+
1280+ *charge_type = POWER_SUPPLY_CHARGE_TYPE_STANDARD;
1281+ if (test_bit(3, &charge_sts)) {
1282+ *charge_type = POWER_SUPPLY_CHARGE_TYPE_FAST;
1283+ }
1284+ if (test_bit(4, &charge_sts)) {
1285+ *charge_type = POWER_SUPPLY_CHARGE_TYPE_TRICKLE;
1286+ }
1287+
1288+ if (test_bit(5, &charge_sts)) {
1289+ *level = POWER_SUPPLY_CAPACITY_LEVEL_CRITICAL;
1290+ }
1291+
1292+ *voltage = get_unaligned_be16(data);
1293+
1294+ return status;
1295+}
1296+
1297+static int hidpp20_battery_get_battery_voltage(struct hidpp_device *hidpp,
1298+ u8 feature_index,
1299+ int *status, int *voltage,
1300+ int *level, int *charge_type)
1301+{
1302+ struct hidpp_report response;
1303+ int ret;
1304+ u8 *params = (u8 *)response.fap.params;
1305+
1306+ ret = hidpp_send_fap_command_sync(hidpp, feature_index,
1307+ CMD_BATTERY_VOLTAGE_GET_BATTERY_VOLTAGE,
1308+ NULL, 0, &response);
1309+
1310+ if (ret > 0) {
1311+ hid_err(hidpp->hid_dev, "%s: received protocol error 0x%02x\n",
1312+ __func__, ret);
1313+ return -EPROTO;
1314+ }
1315+ if (ret)
1316+ return ret;
1317+
1318+ hidpp->capabilities |= HIDPP_CAPABILITY_BATTERY_VOLTAGE;
1319+
1320+ *status = hidpp20_battery_map_status_voltage(params, voltage,
1321+ level, charge_type);
1322+
1323+ return 0;
1324+}
1325+
1326+static int hidpp20_query_battery_voltage_info(struct hidpp_device *hidpp)
1327+{
1328+ u8 feature_type;
1329+ int ret;
1330+ int status, voltage, level, charge_type;
1331+
1332+ if (hidpp->battery.voltage_feature_index == 0xff) {
1333+ ret = hidpp_root_get_feature(hidpp, HIDPP_PAGE_BATTERY_VOLTAGE,
1334+ &hidpp->battery.voltage_feature_index,
1335+ &feature_type);
1336+ if (ret)
1337+ return ret;
1338+ }
1339+
1340+ ret = hidpp20_battery_get_battery_voltage(hidpp,
1341+ hidpp->battery.voltage_feature_index,
1342+ &status, &voltage, &level, &charge_type);
1343+
1344+ if (ret)
1345+ return ret;
1346+
1347+ hidpp->battery.status = status;
1348+ hidpp->battery.voltage = voltage;
1349+ hidpp->battery.level = level;
1350+ hidpp->battery.charge_type = charge_type;
1351+ hidpp->battery.online = status != POWER_SUPPLY_STATUS_NOT_CHARGING;
1352+
1353+ return 0;
1354+}
1355+
1356+static int hidpp20_battery_voltage_event(struct hidpp_device *hidpp,
1357+ u8 *data, int size)
1358+{
1359+ struct hidpp_report *report = (struct hidpp_report *)data;
1360+ int status, voltage, level, charge_type;
1361+
1362+ if (report->fap.feature_index != hidpp->battery.voltage_feature_index ||
1363+ report->fap.funcindex_clientid != EVENT_BATTERY_VOLTAGE_STATUS_BROADCAST)
1364+ return 0;
1365+
1366+ status = hidpp20_battery_map_status_voltage(report->fap.params, &voltage,
1367+ &level, &charge_type);
1368+
1369+ hidpp->battery.online = status != POWER_SUPPLY_STATUS_NOT_CHARGING;
1370+
1371+ if (voltage != hidpp->battery.voltage || status != hidpp->battery.status) {
1372+ hidpp->battery.voltage = voltage;
1373+ hidpp->battery.status = status;
1374+ hidpp->battery.level = level;
1375+ hidpp->battery.charge_type = charge_type;
1376+ if (hidpp->battery.ps)
1377+ power_supply_changed(hidpp->battery.ps);
1378+ }
1379+ return 0;
1380+}
1381+
12251382 static enum power_supply_property hidpp_battery_props[] = {
12261383 POWER_SUPPLY_PROP_ONLINE,
12271384 POWER_SUPPLY_PROP_STATUS,
@@ -1231,6 +1388,7 @@ static enum power_supply_property hidpp_battery_props[] = { · 3 unmodified lines
12311388 POWER_SUPPLY_PROP_SERIAL_NUMBER,
12321389 0, /* placeholder for POWER_SUPPLY_PROP_CAPACITY, */
12331390 0, /* placeholder for POWER_SUPPLY_PROP_CAPACITY_LEVEL, */
1391+ 0, /* placeholder for POWER_SUPPLY_PROP_VOLTAGE_NOW, */
12341392 };
12351393
12361394 static int hidpp_battery_get_property(struct power_supply *psy,
@@ -1268,6 +1426,13 @@ static int hidpp_battery_get_property(struct power_supply *psy, · 31 unmodified lines
12681426 case POWER_SUPPLY_PROP_SERIAL_NUMBER:
12691427 val->strval = hidpp->hid_dev->uniq;
12701428 break;
1429+ case POWER_SUPPLY_PROP_VOLTAGE_NOW:
1430+ /* hardware reports voltage in in mV. sysfs expects uV */
1431+ val->intval = hidpp->battery.voltage * 1000;
1432+ break;
1433+ case POWER_SUPPLY_PROP_CHARGE_TYPE:
1434+ val->intval = hidpp->battery.charge_type;
1435+ break;
12711436 default:
12721437 ret = -EINVAL;
12731438 break;
@@ -1276,6 +1441,24 @@ static int hidpp_battery_get_property(struct power_supply *psy, · 2 unmodified lines
12761441 return ret;
12771442 }
12781443
1444+/* -------------------------------------------------------------------------- */
1445+/* 0x1d4b: Wireless device status */
1446+/* -------------------------------------------------------------------------- */
1447+#define HIDPP_PAGE_WIRELESS_DEVICE_STATUS 0x1d4b
1448+
1449+static int hidpp_set_wireless_feature_index(struct hidpp_device *hidpp)
1450+{
1451+ u8 feature_type;
1452+ int ret;
1453+
1454+ ret = hidpp_root_get_feature(hidpp,
1455+ HIDPP_PAGE_WIRELESS_DEVICE_STATUS,
1456+ &hidpp->wireless_feature_index,
1457+ &feature_type);
1458+
1459+ return ret;
1460+}
1461+
12791462 /* -------------------------------------------------------------------------- */
12801463 /* 0x2120: Hi-resolution scrolling */
12811464 /* -------------------------------------------------------------------------- */
@@ -3091,7 +3274,7 @@ static int hidpp_raw_hidpp_event(struct hidpp_device *hidpp, u8 *data, · 1809 unmodified lines
30913274 }
30923275 }
30933276
3094− if (unlikely(hidpp_report_is_connect_event(report))) {
3277+ if (unlikely(hidpp_report_is_connect_event(hidpp, report))) {
30953278 atomic_set(&hidpp->connected,
30963279 !(report->rap.params[0] & (1 << 6)));
30973280 if (schedule_work(&hidpp->work) == 0)
@@ -3106,6 +3289,9 @@ static int hidpp_raw_hidpp_event(struct hidpp_device *hidpp, u8 *data, · 8 unmodified lines
31063289 ret = hidpp_solar_battery_event(hidpp, data, size);
31073290 if (ret != 0)
31083291 return ret;
3292+ ret = hidpp20_battery_voltage_event(hidpp, data, size);
3293+ if (ret != 0)
3294+ return ret;
31093295 }
31103296
31113297 if (hidpp->capabilities & HIDPP_CAPABILITY_HIDPP10_BATTERY) {
@@ -3227,12 +3413,16 @@ static int hidpp_initialize_battery(struct hidpp_device *hidpp) · 115 unmodified lines
32273413
32283414 hidpp->battery.feature_index = 0xff;
32293415 hidpp->battery.solar_feature_index = 0xff;
3416+ hidpp->battery.voltage_feature_index = 0xff;
32303417
32313418 if (hidpp->protocol_major >= 2) {
32323419 if (hidpp->quirks & HIDPP_QUIRK_CLASS_K750)
32333420 ret = hidpp_solar_request_battery_event(hidpp);
3234− else
3235− ret = hidpp20_query_battery_info(hidpp);
3421+ else {
3422+ ret = hidpp20_query_battery_voltage_info(hidpp);
3423+ if (ret)
3424+ ret = hidpp20_query_battery_info(hidpp);
3425+ }
32363426
32373427 if (ret)
32383428 return ret;
@@ -3257,7 +3447,7 @@ static int hidpp_initialize_battery(struct hidpp_device *hidpp) · 18 unmodified lines
32573447 if (!battery_props)
32583448 return -ENOMEM;
32593449
3260− num_battery_props = ARRAY_SIZE(hidpp_battery_props) - 2;
3450+ num_battery_props = ARRAY_SIZE(hidpp_battery_props) - 3;
32613451
32623452 if (hidpp->capabilities & HIDPP_CAPABILITY_BATTERY_MILEAGE)
32633453 battery_props[num_battery_props++] =
@@ -3267,6 +3457,10 @@ static int hidpp_initialize_battery(struct hidpp_device *hidpp) · 3 unmodified lines
32673457 battery_props[num_battery_props++] =
32683458 POWER_SUPPLY_PROP_CAPACITY_LEVEL;
32693459
3460+ if (hidpp->capabilities & HIDPP_CAPABILITY_BATTERY_VOLTAGE)
3461+ battery_props[num_battery_props++] =
3462+ POWER_SUPPLY_PROP_VOLTAGE_NOW;
3463+
32703464 battery = &hidpp->battery;
32713465
32723466 n = atomic_inc_return(&battery_no) - 1;
@@ -3430,7 +3624,10 @@ static void hidpp_connect_event(struct hidpp_device *hidpp) · 157 unmodified lines
34303624 else
34313625 hidpp10_query_battery_status(hidpp);
34323626 } else if (hidpp->capabilities & HIDPP_CAPABILITY_HIDPP20_BATTERY) {
3433− hidpp20_query_battery_info(hidpp);
3627+ if (hidpp->capabilities & HIDPP_CAPABILITY_BATTERY_VOLTAGE)
3628+ hidpp20_query_battery_voltage_info(hidpp);
3629+ else
3630+ hidpp20_query_battery_info(hidpp);
34343631 }
34353632 if (hidpp->battery.ps)
34363633 power_supply_changed(hidpp->battery.ps);
@@ -3481,10 +3678,11 @@ static int hidpp_get_report_length(struct hid_device *hdev, int id) · 44 unmodified lines
34813678 return report->field[0]->report_count + 1;
34823679 }
34833680
3484−static bool hidpp_validate_device(struct hid_device *hdev)
3681+static u8 hidpp_validate_device(struct hid_device *hdev)
34853682 {
34863683 struct hidpp_device *hidpp = hid_get_drvdata(hdev);
3487− int id, report_length, supported_reports = 0;
3684+ int id, report_length;
3685+ u8 supported_reports = 0;
34883686
34893687 id = REPORT_ID_HIDPP_SHORT;
34903688 report_length = hidpp_get_report_length(hdev, id);
@@ -3492,7 +3690,7 @@ static bool hidpp_validate_device(struct hid_device *hdev) · 1 unmodified line
34923690 if (report_length < HIDPP_REPORT_SHORT_LENGTH)
34933691 goto bad_device;
34943692
3495− supported_reports++;
3693+ supported_reports |= HIDPP_REPORT_SHORT_SUPPORTED;
34963694 }
34973695
34983696 id = REPORT_ID_HIDPP_LONG;
@@ -3501,7 +3699,7 @@ static bool hidpp_validate_device(struct hid_device *hdev) · 2 unmodified lines
35013699 if (report_length < HIDPP_REPORT_LONG_LENGTH)
35023700 goto bad_device;
35033701
3504− supported_reports++;
3702+ supported_reports |= HIDPP_REPORT_LONG_SUPPORTED;
35053703 }
35063704
35073705 id = REPORT_ID_HIDPP_VERY_LONG;
@@ -3511,7 +3709,7 @@ static bool hidpp_validate_device(struct hid_device *hdev) · 3 unmodified lines
35113709 report_length > HIDPP_REPORT_VERY_LONG_MAX_LENGTH)
35123710 goto bad_device;
35133711
3514− supported_reports++;
3712+ supported_reports |= HIDPP_REPORT_VERY_LONG_SUPPORTED;
35153713 hidpp->very_long_report_length = report_length;
35163714 }
35173715
@@ -3560,7 +3758,9 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) · 42 unmodified lines
35603758 /*
35613759 * Make sure the device is HID++ capable, otherwise treat as generic HID
35623760 */
3563− if (!hidpp_validate_device(hdev)) {
3761+ hidpp->supported_reports = hidpp_validate_device(hdev);
3762+
3763+ if (!hidpp->supported_reports) {
35643764 hid_set_drvdata(hdev, NULL);
35653765 devm_kfree(&hdev->dev, hidpp);
35663766 return hid_hw_start(hdev, HID_CONNECT_DEFAULT);
@@ -3617,7 +3817,6 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) · 50 unmodified lines
36173817 if (ret < 0) {
36183818 dev_err(&hdev->dev, "%s:hid_hw_open returned error:%d\n",
36193819 __func__, ret);
3620− hid_hw_stop(hdev);
36213820 goto hid_hw_open_fail;
36223821 }
36233822
@@ -3639,6 +3838,14 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) · 15 unmodified lines
36393838 hidpp_overwrite_name(hdev);
36403839 }
36413840
3841+ if (connected && hidpp->protocol_major >= 2) {
3842+ ret = hidpp_set_wireless_feature_index(hidpp);
3843+ if (ret == -ENOENT)
3844+ hidpp->wireless_feature_index = 0;
3845+ else if (ret)
3846+ goto hid_hw_init_fail;
3847+ }
3848+
36423849 if (connected && (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP)) {
36433850 ret = wtp_get_config(hidpp);
36443851 if (ret)
@@ -3752,6 +3959,8 @@ static const struct hid_device_id hidpp_devices[] = { · 107 unmodified lines
37523959 { LDJ_DEVICE(0x4071), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
37533960 { /* Mouse Logitech MX Master 2S */
37543961 LDJ_DEVICE(0x4069), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
3962+ { /* Mouse Logitech MX Master 3 */
3963+ LDJ_DEVICE(0x4082), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
37553964 { /* Mouse Logitech Performance MX */
37563965 LDJ_DEVICE(0x101a), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_1P0 },
37573966 { /* Keyboard logitech K400 */
@@ -3808,6 +4017,14 @@ static const struct hid_device_id hidpp_devices[] = { · 50 unmodified lines
38084017 { /* MX5500 keyboard over Bluetooth */
38094018 HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb30b),
38104019 .driver_data = HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS },
4020+ { /* MX Master mouse over Bluetooth */
4021+ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb012),
4022+ .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
4023+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01e),
4024+ .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
4025+ { /* MX Master 3 mouse over Bluetooth */
4026+ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb023),
4027+ .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
38114028 {}
38124029 };
38134030
drivers/hid/hidraw.c+9−0
@@ -451,6 +451,15 @@ static long hidraw_ioctl(struct file *file, unsigned int cmd, · 450 unmodified lines
451451 -EFAULT : len;
452452 break;
453453 }
454+
455+ if (_IOC_NR(cmd) == _IOC_NR(HIDIOCGRAWUNIQ(0))) {
456+ int len = strlen(hid->uniq) + 1;
457+ if (len > _IOC_SIZE(cmd))
458+ len = _IOC_SIZE(cmd);
459+ ret = copy_to_user(user_arg, hid->uniq, len) ?
460+ -EFAULT : len;
461+ break;
462+ }
454463 }
455464
456465 ret = -ENOTTY;
include/uapi/linux/hidraw.h+1−0
@@ -39,6 +39,7 @@ struct hidraw_devinfo { · 38 unmodified lines
3939 /* The first byte of SFEATURE and GFEATURE is the report number */
4040 #define HIDIOCSFEATURE(len) _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x06, len)
4141 #define HIDIOCGFEATURE(len) _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x07, len)
42+#define HIDIOCGRAWUNIQ(len) _IOC(_IOC_READ, 'H', 0x08, len)
4243
4344 #define HIDRAW_FIRST_MINOR 0
4445 #define HIDRAW_MAX_DEVICES 64

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t