It seems like the implementation of the --ignore option is broken. In check_symbols_helper, when going through the list of files, a file is added to the list of source files to check if it matches the ignore pattern. Instead, as stated in the comment below this condition, the file should be added if it doesn't match the pattern. This means that when providing an ignore pattern, the only files that will be checked will be the ones we want the ignore, in addition to the Kconfig files that don't match the pattern (the check in parse_kconfig_files is done right)
Showing the changes to scripts (1 of 1 file). Show all
Unified · Split
| @@ -329,7 +329,7 @@ def check_symbols_helper(pool, ignore): · 328 unmodified lines | |||
| 329 | if REGEX_FILE_KCONFIG.match(gitfile): | 329 | if REGEX_FILE_KCONFIG.match(gitfile): |
| 330 | kconfig_files.append(gitfile) | 330 | kconfig_files.append(gitfile) |
| 331 | else: | 331 | else: |
| 332 | if ignore and not re.match(ignore, gitfile): | 332 | if ignore and re.match(ignore, gitfile): |
| 333 | continue | 333 | continue |
| 334 | # add source files that do not match the ignore pattern | 334 | # add source files that do not match the ignore pattern |
| 335 | source_files.append(gitfile) | 335 | source_files.append(gitfile) |