History

mm: thp: correct split_huge_pages file permission

split_huge_pages doesn't support get method at all, so the read permission sounds confusing, change the permission to write only. And, add "\n" to the output of set method to make it more readable.

Yang Shi committed 10 years ago

Commit 145bdaa1 parent c5e06661 file · +2 −2Browse files

Unified · Split

mm/huge_memory.c+2−2
@@ -3452,7 +3452,7 @@ next: · 3451 unmodified lines
3452 }3452 }
3453 }3453 }
3454 3454
3455 pr_info("%lu of %lu THP split", split, total);3455 pr_info("%lu of %lu THP split\n", split, total);
3456 3456
3457 return 0;3457 return 0;
3458}3458}
@@ -3463,7 +3463,7 @@ static int __init split_huge_pages_debugfs(void) · 4 unmodified lines
3463{3463{
3464 void *ret;3464 void *ret;
3465 3465
3466 ret = debugfs_create_file("split_huge_pages", 0644, NULL, NULL,3466 ret = debugfs_create_file("split_huge_pages", 0200, NULL, NULL,
3467 &split_huge_pages_fops);3467 &split_huge_pages_fops);
3468 if (!ret)3468 if (!ret)
3469 pr_warn("Failed to create split_huge_pages in debugfs");3469 pr_warn("Failed to create split_huge_pages in debugfs");

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t