A timer deletion only dequeues the timer but it doesn't shutdown the related costly process wide cputimer counter and the tick dependency. The following code snippet keeps this overhead around for one week after the timer deletion: void trigger_process_counter(void) { timer_t id; struct itimerspec val = { }; val.it_value.tv_sec = 604800; timer_create(CLOCK_PROCESS_CPUTIME_ID, NULL, &id); timer_settime(id, 0, &val, NULL); timer_delete(id); } Make sure the next target's tick recalculates the nearest expiration and clears the process wide counter and tick dependency if necessary.
Unified · Split
| @@ -82,12 +82,14 @@ static inline bool cpu_timer_enqueue(struct timerqueue_head *head, · 81 unmodified lines | ||
| 82 | 82 | return timerqueue_add(head, &ctmr->node); |
| 83 | 83 | } |
| 84 | 84 | |
| 85 | −static inline void cpu_timer_dequeue(struct cpu_timer *ctmr) | |
| 85 | +static inline bool cpu_timer_dequeue(struct cpu_timer *ctmr) | |
| 86 | 86 | { |
| 87 | 87 | if (ctmr->head) { |
| 88 | 88 | timerqueue_del(ctmr->head, &ctmr->node); |
| 89 | 89 | ctmr->head = NULL; |
| 90 | + return true; | |
| 90 | 91 | } |
| 92 | + return false; | |
| 91 | 93 | } |
| 92 | 94 | |
| 93 | 95 | static inline u64 cpu_timer_getexpires(struct cpu_timer *ctmr) |
| @@ -407,6 +407,37 @@ static int posix_cpu_timer_create(struct k_itimer *new_timer) · 406 unmodified lines | ||
| 407 | 407 | return 0; |
| 408 | 408 | } |
| 409 | 409 | |
| 410 | +/* | |
| 411 | + * Dequeue the timer and reset the base if it was its earliest expiration. | |
| 412 | + * It makes sure the next tick recalculates the base next expiration so we | |
| 413 | + * don't keep the costly process wide cputime counter around for a random | |
| 414 | + * amount of time, along with the tick dependency. | |
| 415 | + * | |
| 416 | + * If another timer gets queued between this and the next tick, its | |
| 417 | + * expiration will update the base next event if necessary on the next | |
| 418 | + * tick. | |
| 419 | + */ | |
| 420 | +static void disarm_timer(struct k_itimer *timer, struct task_struct *p) | |
| 421 | +{ | |
| 422 | + struct cpu_timer *ctmr = &timer->it.cpu; | |
| 423 | + struct posix_cputimer_base *base; | |
| 424 | + int clkidx; | |
| 425 | + | |
| 426 | + if (!cpu_timer_dequeue(ctmr)) | |
| 427 | + return; | |
| 428 | + | |
| 429 | + clkidx = CPUCLOCK_WHICH(timer->it_clock); | |
| 430 | + | |
| 431 | + if (CPUCLOCK_PERTHREAD(timer->it_clock)) | |
| 432 | + base = p->posix_cputimers.bases + clkidx; | |
| 433 | + else | |
| 434 | + base = p->signal->posix_cputimers.bases + clkidx; | |
| 435 | + | |
| 436 | + if (cpu_timer_getexpires(ctmr) == base->nextevt) | |
| 437 | + base->nextevt = 0; | |
| 438 | +} | |
| 439 | + | |
| 440 | + | |
| 410 | 441 | /* |
| 411 | 442 | * Clean up a CPU-clock timer that is about to be destroyed. |
| 412 | 443 | * This is called from timer deletion with the timer already locked. |
| @@ -441,7 +472,7 @@ static int posix_cpu_timer_del(struct k_itimer *timer) · 28 unmodified lines | ||
| 441 | 472 | if (timer->it.cpu.firing) |
| 442 | 473 | ret = TIMER_RETRY; |
| 443 | 474 | else |
| 444 | − cpu_timer_dequeue(ctmr); | |
| 475 | + disarm_timer(timer, p); | |
| 445 | 476 | |
| 446 | 477 | unlock_task_sighand(p, &flags); |
| 447 | 478 | } |