If statements don't need multiple parentheses around tested comparisons like "if ((foo == bar))". An == comparison maybe a sign of an intended assignment, so emit a slightly different message if so.
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -3254,6 +3254,20 @@ sub process { · 3253 unmodified lines | |||
| 3254 | } | 3254 | } |
| 3255 | } | 3255 | } |
| 3256 | 3256 | ||
| 3257 | # if statements using unnecessary parentheses - ie: if ((foo == bar)) | ||
| 3258 | if ($^V && $^V ge 5.10.0 && | ||
| 3259 | $line =~ /\bif\s*((?:\(\s*){2,})/) { | ||
| 3260 | my $openparens = $1; | ||
| 3261 | my $count = $openparens =~ tr@\(@\(@; | ||
| 3262 | my $msg = ""; | ||
| 3263 | if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) { | ||
| 3264 | my $comp = $4; #Not $1 because of $LvalOrFunc | ||
| 3265 | $msg = " - maybe == should be = ?" if ($comp eq "=="); | ||
| 3266 | WARN("UNNECESSARY_PARENTHESES", | ||
| 3267 | "Unnecessary parentheses$msg\n" . $herecurr); | ||
| 3268 | } | ||
| 3269 | } | ||
| 3270 | |||
| 3257 | # Return of what appears to be an errno should normally be -'ve | 3271 | # Return of what appears to be an errno should normally be -'ve |
| 3258 | if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) { | 3272 | if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) { |
| 3259 | my $name = $1; | 3273 | my $name = $1; |