History

bpf: support deferring bpf_link dealloc to after RCU grace period

BPF link for some program types is passed as a "context" which can be used by those BPF programs to look up additional information. E.g., for multi-kprobes and multi-uprobes, link is used to fetch BPF cookie values. Because of this runtime dependency, when bpf_link refcnt drops to zero there could still be active BPF programs running accessing link data. This patch adds generic support to defer bpf_link dealloc callback to after RCU GP, if requested. This is done by exposing two different deallocation callbacks, one synchronous and one deferred. If deferred one is provided, bpf_link_free() will schedule dealloc_deferred() callback to happen after RCU GP. BPF is using two flavors of RCU: "classic" non-sleepable one and RCU tasks trace one. The latter is used when sleepable BPF programs are used. bpf_link_free() accommodates that by checking underlying BPF program's sleepable flag, and goes either through normal RCU GP only for non-sleepable, or through RCU tasks trace GP *and* then normal RCU GP (taking into account rcu_trace_implies_rcu_gp() optimization), if BPF program is sleepable. We use this for multi-kprobe and multi-uprobe links, which dereference link during program run. We also preventively switch raw_tp link to use deferred dealloc callback, as upcoming changes in bpf-next tree expose raw_tp link data (specifically, cookie value) to BPF program at runtime as well.

Andrii Nakryiko committed 2 years ago

Commit 1a80dbc1 parent e9c856c3 files · +49 −6Browse files

Showing the changes to kernel/trace (1 of 3 files). Show all

Unified · Split

kernel/trace/bpf_trace.c+2−2
@@ -2728,7 +2728,7 @@ static int bpf_kprobe_multi_link_fill_link_info(const struct bpf_link *link, · 2727 unmodified lines
27282728
27292729 static const struct bpf_link_ops bpf_kprobe_multi_link_lops = {
27302730 .release = bpf_kprobe_multi_link_release,
2731− .dealloc = bpf_kprobe_multi_link_dealloc,
2731+ .dealloc_deferred = bpf_kprobe_multi_link_dealloc,
27322732 .fill_link_info = bpf_kprobe_multi_link_fill_link_info,
27332733 };
27342734
@@ -3242,7 +3242,7 @@ static int bpf_uprobe_multi_link_fill_link_info(const struct bpf_link *link, · 507 unmodified lines
32423242
32433243 static const struct bpf_link_ops bpf_uprobe_multi_link_lops = {
32443244 .release = bpf_uprobe_multi_link_release,
3245− .dealloc = bpf_uprobe_multi_link_dealloc,
3245+ .dealloc_deferred = bpf_uprobe_multi_link_dealloc,
32463246 .fill_link_info = bpf_uprobe_multi_link_fill_link_info,
32473247 };
32483248