If allocation of auxr_dev fails during auxiliary device setup, the error path calls auxiliary_device_uninit(), which eventually invokes bnge_aux_dev_release(). The release callback unconditionally dereferences aux_priv->auxr_dev->pdev to retrieve the parent bnge_dev. Since auxr_dev has not yet been allocated on this failure path, the dereference results in a NULL pointer exception Retrieve the parent bnge_dev from the auxiliary device's parent instead of auxr_dev, and free auxr_dev only when it was successfully allocated. This allows the release callback to correctly clean up partially initialized auxiliary devices.
Unified · Split
| @@ -141,12 +141,15 @@ static void bnge_aux_dev_release(struct device *dev) · 140 unmodified lines | ||
| 141 | 141 | { |
| 142 | 142 | struct bnge_auxr_priv *aux_priv = |
| 143 | 143 | container_of(dev, struct bnge_auxr_priv, aux_dev.dev); |
| 144 | − struct bnge_dev *bd = pci_get_drvdata(aux_priv->auxr_dev->pdev); | |
| 144 | + struct bnge_auxr_dev *auxr_dev = aux_priv->auxr_dev; | |
| 145 | + struct bnge_dev *bd = pci_get_drvdata(to_pci_dev(dev->parent)); | |
| 145 | 146 | |
| 146 | 147 | ida_free(&bnge_aux_dev_ids, aux_priv->id); |
| 147 | − kfree(aux_priv->auxr_dev->auxr_info); | |
| 148 | + if (auxr_dev) { | |
| 149 | + kfree(auxr_dev->auxr_info); | |
| 150 | + kfree(auxr_dev); | |
| 151 | + } | |
| 148 | 152 | bd->auxr_dev = NULL; |
| 149 | − kfree(aux_priv->auxr_dev); | |
| 150 | 153 | kfree(aux_priv); |
| 151 | 154 | bd->aux_priv = NULL; |
| 152 | 155 | } |