This reverts commit 54cc3dbfc10dc3db7cb1cf49aee4477a8398fbde. Zev Weiss reports that the reverted patch may cause a regulator undercount. Here is his report: ... having regulator-dummy set as a supply on my PMBus regulators (instead of having them as their own top-level regulators without an upstream supply) leads to enable-count underflow errors when disabling them: # echo 0 > /sys/bus/platform/devices/efuse01/state [ 906.094477] regulator-dummy: Underflow of regulator enable count [ 906.100563] Failed to disable vout: -EINVAL [ 136.992676] reg-userspace-consumer efuse01: Failed to configure state: -22 Zev reports that reverting the patch fixes the problem. So let's do that for now.
Unified · Split
| @@ -467,7 +467,6 @@ extern const struct regulator_ops pmbus_regulator_ops; · 466 unmodified lines | ||
| 467 | 467 | #define PMBUS_REGULATOR_STEP(_name, _id, _voltages, _step) \ |
| 468 | 468 | [_id] = { \ |
| 469 | 469 | .name = (_name # _id), \ |
| 470 | − .supply_name = "vin", \ | |
| 471 | 470 | .id = (_id), \ |
| 472 | 471 | .of_match = of_match_ptr(_name # _id), \ |
| 473 | 472 | .regulators_node = of_match_ptr("regulators"), \ |