perlcritic is a standard checker for Perl Best Practices. This patch fixes most of the warnings in the get_maintainer script. If kernel programmers are going to have checkpatch they should write clean scripts as well... Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5) Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5) Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5) Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5) Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5) Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Showing the changes to scripts (1 of 1 file). Show all
Unified · Split
| @@ -185,8 +185,9 @@ if (!top_of_kernel_tree($lk_path)) { · 184 unmodified lines | ||
| 185 | 185 | my @typevalue = (); |
| 186 | 186 | my %keyword_hash; |
| 187 | 187 | |
| 188 | −open(MAINT, "<${lk_path}MAINTAINERS") || die "$P: Can't open MAINTAINERS\n"; | |
| 189 | −while (<MAINT>) { | |
| 188 | +open (my $maint, '<', "${lk_path}MAINTAINERS") | |
| 189 | + or die "$P: Can't open MAINTAINERS: $!\n"; | |
| 190 | +while (<$maint>) { | |
| 190 | 191 | my $line = $_; |
| 191 | 192 | |
| 192 | 193 | if ($line =~ m/^(\C):\s*(.*)/) { |
| @@ -211,13 +212,14 @@ while (<MAINT>) { · 18 unmodified lines | ||
| 211 | 212 | push(@typevalue, $line); |
| 212 | 213 | } |
| 213 | 214 | } |
| 214 | −close(MAINT); | |
| 215 | +close($maint); | |
| 215 | 216 | |
| 216 | 217 | my %mailmap; |
| 217 | 218 | |
| 218 | 219 | if ($email_remove_duplicates) { |
| 219 | − open(MAILMAP, "<${lk_path}.mailmap") || warn "$P: Can't open .mailmap\n"; | |
| 220 | − while (<MAILMAP>) { | |
| 220 | + open(my $mailmap, '<', "${lk_path}.mailmap") | |
| 221 | + or warn "$P: Can't open .mailmap: $!\n"; | |
| 222 | + while (<$mailmap>) { | |
| 221 | 223 | my $line = $_; |
| 222 | 224 | |
| 223 | 225 | next if ($line =~ m/^\s*#/); |
| @@ -236,7 +238,7 @@ if ($email_remove_duplicates) { · 12 unmodified lines | ||
| 236 | 238 | $mailmap{$name} = \@arr; |
| 237 | 239 | } |
| 238 | 240 | } |
| 239 | − close(MAILMAP); | |
| 241 | + close($mailmap); | |
| 240 | 242 | } |
| 241 | 243 | |
| 242 | 244 | ## use the filenames on the command line or find the filenames in the patchfiles |
| @@ -262,9 +264,10 @@ foreach my $file (@ARGV) { · 19 unmodified lines | ||
| 262 | 264 | if ($from_filename) { |
| 263 | 265 | push(@files, $file); |
| 264 | 266 | if (-f $file && ($keywords || $file_emails)) { |
| 265 | − open(FILE, "<$file") or die "$P: Can't open ${file}\n"; | |
| 266 | − my $text = do { local($/) ; <FILE> }; | |
| 267 | − close(FILE); | |
| 267 | + open(my $f, '<', $file) | |
| 268 | + or die "$P: Can't open $file: $!\n"; | |
| 269 | + my $text = do { local($/) ; <$f> }; | |
| 270 | + close($f); | |
| 268 | 271 | if ($keywords) { |
| 269 | 272 | foreach my $line (keys %keyword_hash) { |
| 270 | 273 | if ($text =~ m/$keyword_hash{$line}/x) { |
| @@ -280,8 +283,10 @@ foreach my $file (@ARGV) { · 9 unmodified lines | ||
| 280 | 283 | } else { |
| 281 | 284 | my $file_cnt = @files; |
| 282 | 285 | my $lastfile; |
| 283 | − open(PATCH, "<$file") or die "$P: Can't open ${file}\n"; | |
| 284 | − while (<PATCH>) { | |
| 286 | + | |
| 287 | + open(my $patch, '<', $file) | |
| 288 | + or die "$P: Can't open $file: $!\n"; | |
| 289 | + while (<$patch>) { | |
| 285 | 290 | my $patch_line = $_; |
| 286 | 291 | if (m/^\+\+\+\s+(\S+)/) { |
| 287 | 292 | my $filename = $1; |
| @@ -301,7 +306,8 @@ foreach my $file (@ARGV) { · 13 unmodified lines | ||
| 301 | 306 | } |
| 302 | 307 | } |
| 303 | 308 | } |
| 304 | − close(PATCH); | |
| 309 | + close($patch); | |
| 310 | + | |
| 305 | 311 | if ($file_cnt == @files) { |
| 306 | 312 | warn "$P: file '${file}' doesn't appear to be a patch. " |
| 307 | 313 | . "Add -f to options?\n"; |
| @@ -1286,7 +1292,7 @@ sub rfc822_strip_comments { · 978 unmodified lines | ||
| 1286 | 1292 | |
| 1287 | 1293 | # valid: returns true if the parameter is an RFC822 valid address |
| 1288 | 1294 | # |
| 1289 | −sub rfc822_valid ($) { | |
| 1295 | +sub rfc822_valid { | |
| 1290 | 1296 | my $s = rfc822_strip_comments(shift); |
| 1291 | 1297 | |
| 1292 | 1298 | if (!$rfc822re) { |
| @@ -1306,7 +1312,7 @@ sub rfc822_valid ($) { · 13 unmodified lines | ||
| 1306 | 1312 | # from success with no addresses found, because an empty string is |
| 1307 | 1313 | # a valid list. |
| 1308 | 1314 | |
| 1309 | −sub rfc822_validlist ($) { | |
| 1315 | +sub rfc822_validlist { | |
| 1310 | 1316 | my $s = rfc822_strip_comments(shift); |
| 1311 | 1317 | |
| 1312 | 1318 | if (!$rfc822re) { |