seccomp: rework define for SECCOMP_USER_NOTIF_FLAG_CONTINUE

Switch from BIT(0) to (1UL << 0). First, there are already two different forms used in the header, so there's no need to add a third. Second, the BIT() macros is kernel internal and afaict not actually exposed to userspace. Maybe there's some magic there I'm missing but it definitely causes issues when compiling a program that tries to use SECCOMP_USER_NOTIF_FLAG_CONTINUE. It currently fails in the following way: # github.com/lxc/lxd/lxd /usr/bin/ld: $WORK/b001/_x003.o: in function `__do_user_notification_continue': lxd/main_checkfeature.go:240: undefined reference to `BIT' collect2: error: ld returned 1 exit status Switching to (1UL << 0) should prevent that and is more in line what is already done in the rest of the header.

Christian Brauner committed 7 years ago

Commit 23b2c961 parent 2aa8d8d1 file · +1 −1Browse files

Showing the changes to include/uapi/linux (1 of 1 file). Show all

Unified · Split

include/uapi/linux/seccomp.h+1−1

@@ -103,7 +103,7 @@ struct seccomp_notif { · 102 unmodified lines
103	* SECCOMP_USER_NOTIF_FLAG_CONTINUE. Note that SECCOMP_RET_TRACE can equally	103	* SECCOMP_USER_NOTIF_FLAG_CONTINUE. Note that SECCOMP_RET_TRACE can equally
104	* be overriden by SECCOMP_USER_NOTIF_FLAG_CONTINUE.	104	* be overriden by SECCOMP_USER_NOTIF_FLAG_CONTINUE.
105	*/	105	*/
106	#define SECCOMP_USER_NOTIF_FLAG_CONTINUE BIT(0)	106	#define SECCOMP_USER_NOTIF_FLAG_CONTINUE (1UL << 0)
107		107
108	struct seccomp_notif_resp {	108	struct seccomp_notif_resp {
109	__u64 id;	109	__u64 id;