History

hung_task: Display every hung task warning

When khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks. Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The hung_task_warnings sysctl controls this feature. This patch makes it possible for hung_task_warnings to accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks. The special value is -1. To use this value it is necessary to change types from ulong to int.

Aaron Tomlin committed 12 years ago

Commit 270750d1 parent 2397efb4 files · +52 −6Browse files

Showing the changes to kernel (2 of 4 files). Show all

Unified · Split

2 files
  1. kernel/hung_task.c +4 −2
  2. kernel/sysctl.c +5 −3
kernel/hung_task.c+4−2
@@ -37,7 +37,7 @@ int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT; · 36 unmodified lines
3737 */
3838 unsigned long __read_mostly sysctl_hung_task_timeout_secs = CONFIG_DEFAULT_HUNG_TASK_TIMEOUT;
3939
40−unsigned long __read_mostly sysctl_hung_task_warnings = 10;
40+int __read_mostly sysctl_hung_task_warnings = 10;
4141
4242 static int __read_mostly did_panic;
4343
@@ -98,7 +98,9 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout) · 54 unmodified lines
9898
9999 if (!sysctl_hung_task_warnings)
100100 return;
101− sysctl_hung_task_warnings--;
101+
102+ if (sysctl_hung_task_warnings > 0)
103+ sysctl_hung_task_warnings--;
102104
103105 /*
104106 * Ok, the task did not get scheduled for more than 2 minutes,
kernel/sysctl.c+5−3
@@ -122,7 +122,8 @@ extern int blk_iopoll_enabled; · 121 unmodified lines
122122 static int sixty = 60;
123123 #endif
124124
125−static int neg_one = -1;
125+static int __maybe_unused neg_one = -1;
126+
126127 static int zero;
127128 static int __maybe_unused one = 1;
128129 static int __maybe_unused two = 2;
@@ -978,9 +979,10 @@ static struct ctl_table kern_table[] = { · 849 unmodified lines
978979 {
979980 .procname = "hung_task_warnings",
980981 .data = &sysctl_hung_task_warnings,
981− .maxlen = sizeof(unsigned long),
982+ .maxlen = sizeof(int),
982983 .mode = 0644,
983− .proc_handler = proc_doulongvec_minmax,
984+ .proc_handler = proc_dointvec_minmax,
985+ .extra1 = &neg_one,
984986 },
985987 #endif
986988 #ifdef CONFIG_COMPAT

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t