When khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks. Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The hung_task_warnings sysctl controls this feature. This patch makes it possible for hung_task_warnings to accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks. The special value is -1. To use this value it is necessary to change types from ulong to int.
Showing the changes to kernel (2 of 4 files). Show all
Unified · Split
| @@ -37,7 +37,7 @@ int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT; · 36 unmodified lines | ||
| 37 | 37 | */ |
| 38 | 38 | unsigned long __read_mostly sysctl_hung_task_timeout_secs = CONFIG_DEFAULT_HUNG_TASK_TIMEOUT; |
| 39 | 39 | |
| 40 | −unsigned long __read_mostly sysctl_hung_task_warnings = 10; | |
| 40 | +int __read_mostly sysctl_hung_task_warnings = 10; | |
| 41 | 41 | |
| 42 | 42 | static int __read_mostly did_panic; |
| 43 | 43 | |
| @@ -98,7 +98,9 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout) · 54 unmodified lines | ||
| 98 | 98 | |
| 99 | 99 | if (!sysctl_hung_task_warnings) |
| 100 | 100 | return; |
| 101 | − sysctl_hung_task_warnings--; | |
| 101 | + | |
| 102 | + if (sysctl_hung_task_warnings > 0) | |
| 103 | + sysctl_hung_task_warnings--; | |
| 102 | 104 | |
| 103 | 105 | /* |
| 104 | 106 | * Ok, the task did not get scheduled for more than 2 minutes, |
| @@ -122,7 +122,8 @@ extern int blk_iopoll_enabled; · 121 unmodified lines | ||
| 122 | 122 | static int sixty = 60; |
| 123 | 123 | #endif |
| 124 | 124 | |
| 125 | −static int neg_one = -1; | |
| 125 | +static int __maybe_unused neg_one = -1; | |
| 126 | + | |
| 126 | 127 | static int zero; |
| 127 | 128 | static int __maybe_unused one = 1; |
| 128 | 129 | static int __maybe_unused two = 2; |
| @@ -978,9 +979,10 @@ static struct ctl_table kern_table[] = { · 849 unmodified lines | ||
| 978 | 979 | { |
| 979 | 980 | .procname = "hung_task_warnings", |
| 980 | 981 | .data = &sysctl_hung_task_warnings, |
| 981 | − .maxlen = sizeof(unsigned long), | |
| 982 | + .maxlen = sizeof(int), | |
| 982 | 983 | .mode = 0644, |
| 983 | − .proc_handler = proc_doulongvec_minmax, | |
| 984 | + .proc_handler = proc_dointvec_minmax, | |
| 985 | + .extra1 = &neg_one, | |
| 984 | 986 | }, |
| 985 | 987 | #endif |
| 986 | 988 | #ifdef CONFIG_COMPAT |