History

io_uring: remove trace for eventfd

The information on whether eventfd is registered is not very useful and would result in the tracepoint being enclosed in an rcu_readlock in a later patch that tries to avoid ring quiesce for registering eventfd.

Usama Arif committed 4 years ago

Commit 2757be21 parent ffb217a2 files · +6 −10Browse files

Showing the changes to include (1 of 2 files). Show all

Unified · Split

include/trace/events/io_uring.h+5−8
@@ -57,10 +57,9 @@ TRACE_EVENT(io_uring_create, · 56 unmodified lines
5757 * @opcode: describes which operation to perform
5858 * @nr_user_files: number of registered files
5959 * @nr_user_bufs: number of registered buffers
60− * @cq_ev_fd: whether eventfs registered or not
6160 * @ret: return code
6261 *
63− * Allows to trace fixed files/buffers/eventfds, that could be registered to
62+ * Allows to trace fixed files/buffers, that could be registered to
6463 * avoid an overhead of getting references to them for every operation. This
6564 * event, together with io_uring_file_get, can provide a full picture of how
6665 * much overhead one can reduce via fixing.
@@ -68,16 +67,15 @@ TRACE_EVENT(io_uring_create, · 1 unmodified line
6867 TRACE_EVENT(io_uring_register,
6968
7069 TP_PROTO(void *ctx, unsigned opcode, unsigned nr_files,
71− unsigned nr_bufs, bool eventfd, long ret),
70+ unsigned nr_bufs, long ret),
7271
73− TP_ARGS(ctx, opcode, nr_files, nr_bufs, eventfd, ret),
72+ TP_ARGS(ctx, opcode, nr_files, nr_bufs, ret),
7473
7574 TP_STRUCT__entry (
7675 __field( void *, ctx )
7776 __field( unsigned, opcode )
7877 __field( unsigned, nr_files )
7978 __field( unsigned, nr_bufs )
80− __field( bool, eventfd )
8179 __field( long, ret )
8280 ),
8381
@@ -86,14 +84,13 @@ TRACE_EVENT(io_uring_register, · 2 unmodified lines
8684 __entry->opcode = opcode;
8785 __entry->nr_files = nr_files;
8886 __entry->nr_bufs = nr_bufs;
89− __entry->eventfd = eventfd;
9087 __entry->ret = ret;
9188 ),
9289
9390 TP_printk("ring %p, opcode %d, nr_user_files %d, nr_user_bufs %d, "
94− "eventfd %d, ret %ld",
91+ "ret %ld",
9592 __entry->ctx, __entry->opcode, __entry->nr_files,
96− __entry->nr_bufs, __entry->eventfd, __entry->ret)
93+ __entry->nr_bufs, __entry->ret)
9794 );
9895
9996 /**

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t