History

uapi: net_dropmon: drop unused is_drop_point_hw macro

Commit 4ea7e38696c7 ("dropmon: add ability to detect when hardware drops rx packets") introduced is_drop_point_hw, but the symbol was never referenced anywhere in the kernel tree and is currently not used by dropwatch. I could not find, to the best of my abilities, a current out-of-tree user of this macro. The definition also contains a syntax error in its for-loop, so any project that tried to compile against it would fail. Removing the macro therefore eliminates dead code without breaking existing users.

RubenKelevra committed 1 year ago

Commit 2855e431 parent 8bd0af31 file · +0 −7Browse files

Showing the changes to include/uapi (1 of 1 file). Show all

Unified · Split

include/uapi/linux/net_dropmon.h+0−7
@@ -10,13 +10,6 @@ struct net_dm_drop_point { · 9 unmodified lines
1010 __u32 count;
1111 };
1212
13−#define is_drop_point_hw(x) do {\
14− int ____i, ____j;\
15− for (____i = 0; ____i < 8; i ____i++)\
16− ____j |= x[____i];\
17− ____j;\
18−} while (0)
19−
2013 #define NET_DM_CFG_VERSION 0
2114 #define NET_DM_CFG_ALERT_COUNT 1
2215 #define NET_DM_CFG_ALERT_DELAY 2