History

ASoC: topology: Support topology file of ABI v4

Users start to use topology ABI from v4. ABI v5 updated existing manifest and PCM elements. Two previous patches can support these ABI updates in a backward compatible way. So if the topology file from user space is generated by ABI v4, kernel will no longer quit but continue parsing.

Mengdong Lin committed 10 years ago

Commit 288b8da1 parent 8f27c4a2 files · +5 −2Browse files

Unified · Split

2 files
  1. include/uapi/sound/asoc.h +2 −1
  2. sound/soc/soc-topology.c +3 −1
include/uapi/sound/asoc.h+2−1
@@ -83,7 +83,8 @@ · 82 unmodified lines
8383 #define SND_SOC_TPLG_NUM_TEXTS 16
8484
8585 /* ABI version */
86−#define SND_SOC_TPLG_ABI_VERSION 0x5
86+#define SND_SOC_TPLG_ABI_VERSION 0x5 /* current version */
87+#define SND_SOC_TPLG_ABI_VERSION_MIN 0x4 /* oldest version supported */
8788
8889 /* Max size of TLV data */
8990 #define SND_SOC_TPLG_TLV_SIZE 32
sound/soc/soc-topology.c+3−1
@@ -2056,7 +2056,9 @@ static int soc_valid_header(struct soc_tplg *tplg, · 2055 unmodified lines
20562056 return -EINVAL;
20572057 }
20582058
2059− if (hdr->abi != SND_SOC_TPLG_ABI_VERSION) {
2059+ /* Support ABI from version 4 */
2060+ if (hdr->abi > SND_SOC_TPLG_ABI_VERSION
2061+ || hdr->abi < SND_SOC_TPLG_ABI_VERSION_MIN) {
20602062 dev_err(tplg->dev,
20612063 "ASoC: pass %d invalid ABI version got 0x%x need 0x%x at offset 0x%lx size 0x%zx.\n",
20622064 tplg->pass, hdr->abi,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t