History

drm/i915: take a power domain reference while checking the HDMI live status

There are platforms that don't need the full GMBUS power domain (BXT) while others do (PCH, VLV/CHV). For optimizing this we would need to add a new power domain, but it's not clear how much we would benefit given the short time we hold the reference. So for now let's keep things simple. v2: - fix commit message, PCH won't take any redundant power resource after this change (Ville)

Imre Deak committed 10 years ago

Commit 29bb94b1 parent 69172f21 file · +4 −0Browse files

Unified · Split

drivers/gpu/drm/i915/intel_hdmi.c+4−0
@@ -1393,6 +1393,8 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) · 1392 unmodified lines
1393 DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",1393 DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
1394 connector->base.id, connector->name);1394 connector->base.id, connector->name);
1395 1395
1396 intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS);
1397
1396 while (!live_status && --retry) {1398 while (!live_status && --retry) {
1397 live_status = intel_digital_port_connected(dev_priv,1399 live_status = intel_digital_port_connected(dev_priv,
1398 hdmi_to_dig_port(intel_hdmi));1400 hdmi_to_dig_port(intel_hdmi));
@@ -1412,6 +1414,8 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) · 13 unmodified lines
1412 } else1414 } else
1413 status = connector_status_disconnected;1415 status = connector_status_disconnected;
1414 1416
1417 intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS);
1418
1415 return status;1419 return status;
1416}1420}
1417 1421

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t