History

net: thunderx: use proper interface type for RGMII

The configuration of the OCTEONTX XCV_DLL_CTL register via xcv_init_hw() is such that the RGMII RX delay is bypassed leaving the RGMII TX delay enabled in the MAC: /* Configure DLL - enable or bypass * TX no bypass, RX bypass */ cfg = readq_relaxed(xcv->reg_base + XCV_DLL_CTL); cfg &= ~0xFF03; cfg |= CLKRX_BYP; writeq_relaxed(cfg, xcv->reg_base + XCV_DLL_CTL); This would coorespond to a interface type of PHY_INTERFACE_MODE_RGMII_RXID and not PHY_INTERFACE_MODE_RGMII. Fixing this allows RGMII PHY drivers to do the right thing (enable RX delay in the PHY) instead of erroneously enabling both delays in the PHY.

Tim Harvey committed 6 years ago

Commit 29ca3b31 parent c76b3051 file · +1 −1Browse files

Unified · Split

drivers/net/ethernet/cavium/thunder/thunder_bgx.c+1−1
@@ -1039,7 +1039,7 @@ static int phy_interface_mode(u8 lmac_type) · 1038 unmodified lines
1039 if (lmac_type == BGX_MODE_QSGMII)1039 if (lmac_type == BGX_MODE_QSGMII)
1040 return PHY_INTERFACE_MODE_QSGMII;1040 return PHY_INTERFACE_MODE_QSGMII;
1041 if (lmac_type == BGX_MODE_RGMII)1041 if (lmac_type == BGX_MODE_RGMII)
1042 return PHY_INTERFACE_MODE_RGMII;1042 return PHY_INTERFACE_MODE_RGMII_RXID;
1043 1043
1044 return PHY_INTERFACE_MODE_SGMII;1044 return PHY_INTERFACE_MODE_SGMII;
1045}1045}

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t