History

soc: ti: knav_dma: Use proper enum in pktdma_init_chan

Clang warns when one enumerated type is implicitly converted to another: drivers/soc/ti/knav_dma.c:601:20: warning: implicit conversion from enumeration type 'enum dma_data_direction' to different enumeration type 'enum dma_transfer_direction' [-Wenum-conversion] chan->direction = DMA_NONE; ~ ^~~~~~~~ 1 warning generated. While DMA_NONE and DMA_TRANS_NONE have different values, there is no functional change because direction is never checked against DMA_NONE, only against DMA_MEM_TO_DEV and DMA_DEV_TO_MEM.

Nathan Chancellor committed 7 years ago

Commit 2b13ef11 parent 5953c881 file · +1 −1Browse files

Unified · Split

drivers/soc/ti/knav_dma.c+1−1
@@ -598,7 +598,7 @@ static int pktdma_init_chan(struct knav_dma_device *dma, · 597 unmodified lines
598598
599599 INIT_LIST_HEAD(&chan->list);
600600 chan->dma = dma;
601− chan->direction = DMA_NONE;
601+ chan->direction = DMA_TRANS_NONE;
602602 atomic_set(&chan->ref_count, 0);
603603 spin_lock_init(&chan->lock);
604604

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t