History

ixgbe: don't set RXDCTL.RLPML for 82599

commit 2de6aa3a666e ("ixgbe: Add support for padding packet") Uses RXDCTL.RLPML to limit the maximum frame size on Rx when using build_skb. Unfortunately that register does not work on 82599. Added an explicit check to avoid setting this register on 82599 MAC. Extended the comment related to the setting of RXDCTL.RLPML to better explain its purpose.

Emil Tantilov committed 8 years ago

Commit 2bafa8f1 parent fd492221 file · +6 −2Browse files

Unified · Split

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+6−2
@@ -4133,11 +4133,15 @@ void ixgbe_configure_rx_ring(struct ixgbe_adapter *adapter, · 4132 unmodified lines
41334133 rxdctl &= ~0x3FFFFF;
41344134 rxdctl |= 0x080420;
41354135 #if (PAGE_SIZE < 8192)
4136− } else {
4136+ /* RXDCTL.RLPML does not work on 82599 */
4137+ } else if (hw->mac.type != ixgbe_mac_82599EB) {
41374138 rxdctl &= ~(IXGBE_RXDCTL_RLPMLMASK |
41384139 IXGBE_RXDCTL_RLPML_EN);
41394140
4140− /* Limit the maximum frame size so we don't overrun the skb */
4141+ /* Limit the maximum frame size so we don't overrun the skb.
4142+ * This can happen in SRIOV mode when the MTU of the VF is
4143+ * higher than the MTU of the PF.
4144+ */
41414145 if (ring_uses_build_skb(ring) &&
41424146 !test_bit(__IXGBE_RX_3K_BUFFER, &ring->state))
41434147 rxdctl |= IXGBE_MAX_2K_FRAME_BUILD_SKB |