For the MMC_CAP2_SDIO_IRQ_NOTHREAD case and when using sdio_signal_irq(), the ->ack_sdio_irq() is already mandatory, which was not the case for those host drivers that called sdio_run_irqs() directly. As there are no longer any drivers calling sdio_run_irqs(), let's clarify the code by dropping the unnecessary check and explicitly state that the callback is mandatory in the header file.
Showing the changes to include/linux (1 of 2 files). Show all
Unified · Split
| @@ -128,6 +128,7 @@ struct mmc_host_ops { · 127 unmodified lines | |||
| 128 | int (*get_cd)(struct mmc_host *host); | 128 | int (*get_cd)(struct mmc_host *host); |
| 129 | 129 | ||
| 130 | void (*enable_sdio_irq)(struct mmc_host *host, int enable); | 130 | void (*enable_sdio_irq)(struct mmc_host *host, int enable); |
| 131 | /* Mandatory callback when using MMC_CAP2_SDIO_IRQ_NOTHREAD. */ | ||
| 131 | void (*ack_sdio_irq)(struct mmc_host *host); | 132 | void (*ack_sdio_irq)(struct mmc_host *host); |
| 132 | 133 | ||
| 133 | /* optional callback for HC quirks */ | 134 | /* optional callback for HC quirks */ |