It doesn't seem right for the thermal subsystem to export a symbol named generate_netlink_event. This function is thermal-specific and its name should reflect that fact. Rename it to thermal_generate_netlink_event.
Unified · Split
| @@ -284,7 +284,7 @@ method, the sys I/F structure will be built like this: · 283 unmodified lines | ||
| 284 | 284 | The framework includes a simple notification mechanism, in the form of a |
| 285 | 285 | netlink event. Netlink socket initialization is done during the _init_ |
| 286 | 286 | of the framework. Drivers which intend to use the notification mechanism |
| 287 | −just need to call generate_netlink_event() with two arguments viz | |
| 287 | +just need to call thermal_generate_netlink_event() with two arguments viz | |
| 288 | 288 | (originator, event). Typically the originator will be an integer assigned |
| 289 | 289 | to a thermal_zone_device when it registers itself with the framework. The |
| 290 | 290 | event will be one of:{THERMAL_AUX0, THERMAL_AUX1, THERMAL_CRITICAL, |
| @@ -1304,7 +1304,7 @@ static struct genl_multicast_group thermal_event_mcgrp = { · 1303 unmodified lines | ||
| 1304 | 1304 | .name = THERMAL_GENL_MCAST_GROUP_NAME, |
| 1305 | 1305 | }; |
| 1306 | 1306 | |
| 1307 | −int generate_netlink_event(u32 orig, enum events event) | |
| 1307 | +int thermal_generate_netlink_event(u32 orig, enum events event) | |
| 1308 | 1308 | { |
| 1309 | 1309 | struct sk_buff *skb; |
| 1310 | 1310 | struct nlattr *attr; |
| @@ -1363,7 +1363,7 @@ int generate_netlink_event(u32 orig, enum events event) · 52 unmodified lines | ||
| 1363 | 1363 | |
| 1364 | 1364 | return result; |
| 1365 | 1365 | } |
| 1366 | −EXPORT_SYMBOL(generate_netlink_event); | |
| 1366 | +EXPORT_SYMBOL(thermal_generate_netlink_event); | |
| 1367 | 1367 | |
| 1368 | 1368 | static int genetlink_init(void) |
| 1369 | 1369 | { |
| @@ -152,9 +152,9 @@ struct thermal_cooling_device *thermal_cooling_device_register(char *, void *, · 151 unmodified lines | ||
| 152 | 152 | void thermal_cooling_device_unregister(struct thermal_cooling_device *); |
| 153 | 153 | |
| 154 | 154 | #ifdef CONFIG_NET |
| 155 | −extern int generate_netlink_event(u32 orig, enum events event); | |
| 155 | +extern int thermal_generate_netlink_event(u32 orig, enum events event); | |
| 156 | 156 | #else |
| 157 | −static inline int generate_netlink_event(u32 orig, enum events event) | |
| 157 | +static inline int thermal_generate_netlink_event(u32 orig, enum events event) | |
| 158 | 158 | { |
| 159 | 159 | return 0; |
| 160 | 160 | } |