History

Merge branch 'i2c-embedded/for-current' of git://git.pengutronix.de/git/wsa/linux

Pull i2c-embedded fixes from Wolfram Sang: "Some bugfixes for the "embedded" part of the I2C subsystem. The fixes affect mostly drivers which have been largely reworked lately and where regressions appeared." * 'i2c-embedded/for-current' of git://git.pengutronix.de/git/wsa/linux: i2c: tegra: protect suspend/resume callbacks with CONFIG_PM_SLEEP i2c: diolan-u2c: Fix master_xfer return code I2C: OMAP: xfer: fix runtime PM get/put balance on error i2c: nomadik: Add default configuration into the Nomadik I2C driver

Linus Torvalds committed 14 years ago

Commit 2e2d8c92 parents fec3c03 371e67c4 files · +21 −12Browse files

Unified · Split

4 files
  1. drivers/i2c/busses/i2c-diolan-u2c.c +1 −0
  2. drivers/i2c/busses/i2c-nomadik.c +18 −10
  3. drivers/i2c/busses/i2c-omap.c +1 −1
  4. drivers/i2c/busses/i2c-tegra.c +1 −1
drivers/i2c/busses/i2c-diolan-u2c.c+1−0
@@ -405,6 +405,7 @@ static int diolan_usb_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, · 404 unmodified lines
405405 }
406406 }
407407 }
408+ ret = num;
408409 abort:
409410 sret = diolan_i2c_stop(dev);
410411 if (sret < 0 && ret >= 0)
drivers/i2c/busses/i2c-nomadik.c+18−10
@@ -350,10 +350,6 @@ static void setup_i2c_controller(struct nmk_i2c_dev *dev) · 349 unmodified lines
350350
351351 i2c_clk = clk_get_rate(dev->clk);
352352
353− /* fallback to std. mode if machine has not provided it */
354− if (dev->cfg.clk_freq == 0)
355− dev->cfg.clk_freq = 100000;
356−
357353 /*
358354 * The spec says, in case of std. mode the divider is
359355 * 2 whereas it is 3 for fast and fastplus mode of
@@ -911,20 +907,32 @@ static const struct i2c_algorithm nmk_i2c_algo = { · 551 unmodified lines
911907 .functionality = nmk_i2c_functionality
912908 };
913909
910+static struct nmk_i2c_controller u8500_i2c = {
911+ /*
912+ * Slave data setup time; 250ns, 100ns, and 10ns, which
913+ * is 14, 6 and 2 respectively for a 48Mhz i2c clock.
914+ */
915+ .slsu = 0xe,
916+ .tft = 1, /* Tx FIFO threshold */
917+ .rft = 8, /* Rx FIFO threshold */
918+ .clk_freq = 400000, /* fast mode operation */
919+ .timeout = 200, /* Slave response timeout(ms) */
920+ .sm = I2C_FREQ_MODE_FAST,
921+};
922+
914923 static atomic_t adapter_id = ATOMIC_INIT(0);
915924
916925 static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
917926 {
918927 int ret = 0;
919− struct nmk_i2c_controller *pdata =
920− adev->dev.platform_data;
928+ struct nmk_i2c_controller *pdata = adev->dev.platform_data;
921929 struct nmk_i2c_dev *dev;
922930 struct i2c_adapter *adap;
923931
924− if (!pdata) {
925− dev_warn(&adev->dev, "no platform data\n");
926− return -ENODEV;
927− }
932+ if (!pdata)
933+ /* No i2c configuration found, using the default. */
934+ pdata = &u8500_i2c;
935+
928936 dev = kzalloc(sizeof(struct nmk_i2c_dev), GFP_KERNEL);
929937 if (!dev) {
930938 dev_err(&adev->dev, "cannot allocate memory\n");
drivers/i2c/busses/i2c-omap.c+1−1
@@ -584,7 +584,7 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) · 583 unmodified lines
584584
585585 r = pm_runtime_get_sync(dev->dev);
586586 if (IS_ERR_VALUE(r))
587− return r;
587+ goto out;
588588
589589 r = omap_i2c_wait_for_bb(dev);
590590 if (r < 0)
drivers/i2c/busses/i2c-tegra.c+1−1
@@ -712,7 +712,7 @@ static int __devexit tegra_i2c_remove(struct platform_device *pdev) · 711 unmodified lines
712712 return 0;
713713 }
714714
715−#ifdef CONFIG_PM
715+#ifdef CONFIG_PM_SLEEP
716716 static int tegra_i2c_suspend(struct device *dev)
717717 {
718718 struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);