History

perf bpf: Return value with unlocking in perf_env__find_btf()

In perf_env__find_btf(), we're returning without unlocking "env->bpf_progs.lock". There may be cause lockdep issue. Detected by CoversityScan, CID# 1444762:(program hangs(LOCK))

Bo YU committed 7 years ago

Commit 2e712671 parent 18045691 file · +1 −1Browse files

Unified · Split

tools/perf/util/env.c+1−1
@@ -115,8 +115,8 @@ struct btf_node *perf_env__find_btf(struct perf_env *env, __u32 btf_id) · 114 unmodified lines
115115 }
116116 node = NULL;
117117
118− up_read(&env->bpf_progs.lock);
119118 out:
119+ up_read(&env->bpf_progs.lock);
120120 return node;
121121 }
122122

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t