History

s390/ap: fix error handling in __verify_queue_reservations()

The AP bus's __verify_queue_reservations function increments the ref count for the device driver passed in as a parameter, but fails to decrement it before returning control to the caller. This will prevents any subsequent removal of the module.

Tony Krowiak committed 4 years ago

Commit 2f232561 parent a0b09871 file · +1 −1Browse files

Unified · Split

drivers/s390/crypto/ap_bus.c+1−1
@@ -1435,7 +1435,7 @@ static int __verify_queue_reservations(struct device_driver *drv, void *data) · 1434 unmodified lines
1435 if (ap_drv->in_use) {1435 if (ap_drv->in_use) {
1436 rc = ap_drv->in_use(ap_perms.apm, newaqm);1436 rc = ap_drv->in_use(ap_perms.apm, newaqm);
1437 if (rc)1437 if (rc)
1438 return -EBUSY;1438 rc = -EBUSY;
1439 }1439 }
1440 1440
1441 /* release the driver's module */1441 /* release the driver's module */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t