Trying to build livepatch on powerpc/32 results in: kernel/livepatch/core.c: In function 'klp_resolve_symbols': kernel/livepatch/core.c:221:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 221 | sym = (Elf64_Sym *)sechdrs[symndx].sh_addr + ELF_R_SYM(relas[i].r_info); | ^ kernel/livepatch/core.c:221:21: error: assignment to 'Elf32_Sym *' {aka 'struct elf32_sym *'} from incompatible pointer type 'Elf64_Sym *' {aka 'struct elf64_sym *'} [-Werror=incompatible-pointer-types] 221 | sym = (Elf64_Sym *)sechdrs[symndx].sh_addr + ELF_R_SYM(relas[i].r_info); | ^ kernel/livepatch/core.c: In function 'klp_apply_section_relocs': kernel/livepatch/core.c:312:35: error: passing argument 1 of 'klp_resolve_symbols' from incompatible pointer type [-Werror=incompatible-pointer-types] 312 | ret = klp_resolve_symbols(sechdrs, strtab, symndx, sec, sec_objname); | ^~~~~~~ | | | Elf32_Shdr * {aka struct elf32_shdr *} kernel/livepatch/core.c:193:44: note: expected 'Elf64_Shdr *' {aka 'struct elf64_shdr *'} but argument is of type 'Elf32_Shdr *' {aka 'struct elf32_shdr *'} 193 | static int klp_resolve_symbols(Elf64_Shdr *sechdrs, const char *strtab, | ~~~~~~~~~~~~^~~~~~~ Fix it by using the right types instead of forcing 64 bits types.
Unified · Split
| @@ -190,7 +190,7 @@ static int klp_find_object_symbol(const char *objname, const char *name, · 189 unmodified lines | ||
| 190 | 190 | return -EINVAL; |
| 191 | 191 | } |
| 192 | 192 | |
| 193 | −static int klp_resolve_symbols(Elf64_Shdr *sechdrs, const char *strtab, | |
| 193 | +static int klp_resolve_symbols(Elf_Shdr *sechdrs, const char *strtab, | |
| 194 | 194 | unsigned int symndx, Elf_Shdr *relasec, |
| 195 | 195 | const char *sec_objname) |
| 196 | 196 | { |
| @@ -218,7 +218,7 @@ static int klp_resolve_symbols(Elf64_Shdr *sechdrs, const char *strtab, · 21 unmodified lines | ||
| 218 | 218 | relas = (Elf_Rela *) relasec->sh_addr; |
| 219 | 219 | /* For each rela in this klp relocation section */ |
| 220 | 220 | for (i = 0; i < relasec->sh_size / sizeof(Elf_Rela); i++) { |
| 221 | − sym = (Elf64_Sym *)sechdrs[symndx].sh_addr + ELF_R_SYM(relas[i].r_info); | |
| 221 | + sym = (Elf_Sym *)sechdrs[symndx].sh_addr + ELF_R_SYM(relas[i].r_info); | |
| 222 | 222 | if (sym->st_shndx != SHN_LIVEPATCH) { |
| 223 | 223 | pr_err("symbol %s is not marked as a livepatch symbol\n", |
| 224 | 224 | strtab + sym->st_name); |