History

docs: Don't push Sphinx upgrades quite so readily

The sphinx-pre-install script will put out a verbose message recommending an upgrade for anybody running less than 2.4.4 - which was only released in March. So *everybody* will see that warning at this point. Let's only warn if the user is below our generally recommended version (1.7.9 currently). It might be good to put out a warning if people are explicitly making PDF files, but would need to be done in a different place and relatively few people do that.

Jonathan Corbet committed 6 years ago

Commit 2f444ef1 parent b3a9e3b1 file · +0 −4Browse files

Unified · Split

scripts/sphinx-pre-install+0−4
@@ -323,10 +323,6 @@ sub check_sphinx() · 322 unmodified lines
323 $rec_sphinx_upgrade = 1;323 $rec_sphinx_upgrade = 1;
324 return;324 return;
325 }325 }
326 if ($cur_version lt $min_pdf_version) {
327 $rec_sphinx_upgrade = 1;
328 return;
329 }
330 326
331 # On version check mode, just assume Sphinx has all mandatory deps327 # On version check mode, just assume Sphinx has all mandatory deps
332 exit (0) if ($version_check);328 exit (0) if ($version_check);