History

KVM: Drop kvm_reload_remote_mmus(), open code request in x86 users

Remove the generic kvm_reload_remote_mmus() and open code its functionality into the two x86 callers. x86 is (obviously) the only architecture that uses the hook, and is also the only architecture that uses KVM_REQ_MMU_RELOAD in a way that's consistent with the name. That will change in a future patch, as x86's usage when zapping a single shadow page x86 doesn't actually _need_ to reload all vCPUs' MMUs, only MMUs whose root is being zapped actually need to be reloaded. s390 also uses KVM_REQ_MMU_RELOAD, but for a slightly different purpose. Drop the generic code in anticipation of implementing s390 and x86 arch specific requests, which will allow dropping KVM_REQ_MMU_RELOAD entirely. Opportunistically reword the x86 TDP MMU comment to avoid making references to functions (and requests!) when possible, and to remove the rather ambiguous "this". No functional change intended.

Sean Christopherson committed 4 years ago

Commit 2f6f66c1 parent f6d0a253 files · +7 −13Browse files

Showing the changes to include (1 of 3 files). Show all

Unified · Split

include/linux/kvm_host.h+0−1
@@ -1325,7 +1325,6 @@ int kvm_vcpu_yield_to(struct kvm_vcpu *target); · 1324 unmodified lines
1325void kvm_vcpu_on_spin(struct kvm_vcpu *vcpu, bool usermode_vcpu_not_eligible);1325void kvm_vcpu_on_spin(struct kvm_vcpu *vcpu, bool usermode_vcpu_not_eligible);
1326 1326
1327void kvm_flush_remote_tlbs(struct kvm *kvm);1327void kvm_flush_remote_tlbs(struct kvm *kvm);
1328void kvm_reload_remote_mmus(struct kvm *kvm);
1329 1328
1330#ifdef KVM_ARCH_NR_OBJS_PER_MEMORY_CACHE1329#ifdef KVM_ARCH_NR_OBJS_PER_MEMORY_CACHE
1331int kvm_mmu_topup_memory_cache(struct kvm_mmu_memory_cache *mc, int min);1330int kvm_mmu_topup_memory_cache(struct kvm_mmu_memory_cache *mc, int min);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t