History

namei: allow restricted O_CREAT of FIFOs and regular files

Disallows open of FIFOs or regular files not owned by the user in world writable sticky directories, unless the owner is the same as that of the directory or the file is opened without the O_CREAT flag. The purpose is to make data spoofing attacks harder. This protection can be turned on and off separately for FIFOs and regular files via sysctl, just like the symlinks/hardlinks protection. This patch is based on Openwall's "HARDEN_FIFO" feature by Solar Designer. This is a brief list of old vulnerabilities that could have been prevented by this feature, some of them even allow for privilege escalation: CVE-2000-1134 CVE-2007-3852 CVE-2008-0525 CVE-2009-0416 CVE-2011-4834 CVE-2015-1838 CVE-2015-7442 CVE-2016-7489 This list is not meant to be complete. It's difficult to track down all vulnerabilities of this kind because they were often reported without any mention of this particular attack vector. In fact, before hardlinks/symlinks restrictions, fifos/regular files weren't the favorite vehicle to exploit them. [s.mesoraca16@gmail.com: fix bug reported by Dan Carpenter] Link: https://lkml.kernel.org/r/20180426081456.GA7060@mwanda Link: http://lkml.kernel.org/r/1524829819-11275-1-git-send-email-s.mesoraca16@gmail.com [keescook@chromium.org: drop pr_warn_ratelimited() in favor of audit changes in the future] [keescook@chromium.org: adjust commit subjet] Link: http://lkml.kernel.org/r/20180416175918.GA13494@beast Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org> Suggested-by: Solar Designer <solar@openwall.com> Suggested-by: Kees Cook <keescook@chromium.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Salvatore Mesoraca committed 8 years ago

Commit 30aba661 parent dc257274 files · +106 −3Browse files

Showing the changes to kernel (1 of 4 files). Show all

Unified · Split

kernel/sysctl.c+18−0
@@ -1807,6 +1807,24 @@ static struct ctl_table fs_table[] = { · 1806 unmodified lines
18071807 .extra1 = &zero,
18081808 .extra2 = &one,
18091809 },
1810+ {
1811+ .procname = "protected_fifos",
1812+ .data = &sysctl_protected_fifos,
1813+ .maxlen = sizeof(int),
1814+ .mode = 0600,
1815+ .proc_handler = proc_dointvec_minmax,
1816+ .extra1 = &zero,
1817+ .extra2 = &two,
1818+ },
1819+ {
1820+ .procname = "protected_regular",
1821+ .data = &sysctl_protected_regular,
1822+ .maxlen = sizeof(int),
1823+ .mode = 0600,
1824+ .proc_handler = proc_dointvec_minmax,
1825+ .extra1 = &zero,
1826+ .extra2 = &two,
1827+ },
18101828 {
18111829 .procname = "suid_dumpable",
18121830 .data = &suid_dumpable,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t