History

iio: dac: mcp4725: fix odd_ptr_err.cocci warnings

PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Julia Lawall committed 10 years ago

Commit 30df2d11 parent dbdef9b1 file · +1 −1Browse files

Unified · Split

drivers/iio/dac/mcp4725.c+1−1
@@ -449,7 +449,7 @@ static int mcp4725_probe(struct i2c_client *client, · 448 unmodified lines
449449 if (pdata->use_vref) {
450450 data->vref_reg = devm_regulator_get(&client->dev, "vref");
451451 if (IS_ERR(data->vref_reg)) {
452− err = PTR_ERR(data->vdd_reg);
452+ err = PTR_ERR(data->vref_reg);
453453 goto err_disable_vdd_reg;
454454 }
455455

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t