PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Unified · Split
| @@ -449,7 +449,7 @@ static int mcp4725_probe(struct i2c_client *client, · 448 unmodified lines | ||
| 449 | 449 | if (pdata->use_vref) { |
| 450 | 450 | data->vref_reg = devm_regulator_get(&client->dev, "vref"); |
| 451 | 451 | if (IS_ERR(data->vref_reg)) { |
| 452 | − err = PTR_ERR(data->vdd_reg); | |
| 452 | + err = PTR_ERR(data->vref_reg); | |
| 453 | 453 | goto err_disable_vdd_reg; |
| 454 | 454 | } |
| 455 | 455 | |