History

checkpatch: disallow --git and --file/--fix

Don't allow these options to be combined. Miscellanea: o Add missing $P: to some die("reason message") output

Joe Perches committed 6 years ago

Commit 32f30ca1 parent a55ee0c1 file · +4 −2Browse files

Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all

Unified · Split

scripts/checkpatch.pl+4−2
@@ -246,6 +246,8 @@ list_types(0) if ($list_types); · 245 unmodified lines
246246 $fix = 1 if ($fix_inplace);
247247 $check_orig = $check;
248248
249+die "$P: --git cannot be used with --file or --fix\n" if ($git && ($file || $fix));
250+
249251 my $exit = 0;
250252
251253 my $perl_version_ok = 1;
@@ -269,11 +271,11 @@ if ($color =~ /^[01]$/) { · 17 unmodified lines
269271 } elsif ($color =~ /^auto$/i) {
270272 $color = (-t STDOUT);
271273 } else {
272− die "Invalid color mode: $color\n";
274+ die "$P: Invalid color mode: $color\n";
273275 }
274276
275277 # skip TAB size 1 to avoid additional checks on $tabsize - 1
276−die "Invalid TAB size: $tabsize\n" if ($tabsize < 2);
278+die "$P: Invalid TAB size: $tabsize\n" if ($tabsize < 2);
277279
278280 sub hash_save_array_words {
279281 my ($hashRef, $arrayRef) = @_;