History

pNFS: Add tracking to limit the number of pNFS retries

When the client is reading or writing using pNFS, and hits an error on the DS, then it typically sends a LAYOUTERROR and/or LAYOUTRETURN to the MDS, before redirtying the failed pages, and going for a new round of reads/writebacks. The problem is that if the server has no way to fix the DS, then we may need a way to interrupt this loop after a set number of attempts have been made. This patch adds an optional module parameter that allows the admin to specify how many times to retry the read/writeback process before failing with a fatal error. The default behaviour is to retry forever.

Trond Myklebust committed 7 years ago

Commit 33344e01 parent 28b1d3f5 files · +36 −2Browse files

Showing the changes to include/linux (1 of 5 files). Show all

Unified · Split

include/linux/nfs_page.h+3−1
@@ -53,6 +53,7 @@ struct nfs_page { · 52 unmodified lines
5353 struct nfs_write_verifier wb_verf; /* Commit cookie */
5454 struct nfs_page *wb_this_page; /* list of reqs for this page */
5555 struct nfs_page *wb_head; /* head pointer for req list */
56+ unsigned short wb_nio; /* Number of I/O attempts */
5657 };
5758
5859 struct nfs_pageio_descriptor;
@@ -87,7 +88,6 @@ struct nfs_pgio_mirror { · 28 unmodified lines
8788 };
8889
8990 struct nfs_pageio_descriptor {
90− unsigned char pg_moreio : 1;
9191 struct inode *pg_inode;
9292 const struct nfs_pageio_ops *pg_ops;
9393 const struct nfs_rw_ops *pg_rw_ops;
@@ -105,6 +105,8 @@ struct nfs_pageio_descriptor { · 11 unmodified lines
105105 struct nfs_pgio_mirror pg_mirrors_static[1];
106106 struct nfs_pgio_mirror *pg_mirrors_dynamic;
107107 u32 pg_mirror_idx; /* current mirror */
108+ unsigned short pg_maxretrans;
109+ unsigned char pg_moreio : 1;
108110 };
109111
110112 /* arbitrarily selected limit to number of mirrors */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t