History

workqueue: Remove unnecessary kfree() call in rcu_free_wq()

The data structure member "wq->rescuer" was reset to a null pointer in one if branch. It was passed to a call of the function "kfree" in the callback function "rcu_free_wq" (which was eventually executed). The function "kfree" does not perform more meaningful data processing for a passed null pointer (besides immediately returning from such a call). Thus delete this function call which became unnecessary with the referenced software update. Fixes: def98c84b6cd ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")

Zhang Qiang committed 6 years ago

Commit 342ed241 parent b92b36e1 file · +0 −1Browse files

Showing the changes to kernel/workqueue.c (1 of 1 file). Show all

Unified · Split

kernel/workqueue.c+0−1
@@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu) · 3490 unmodified lines
34913491 else
34923492 free_workqueue_attrs(wq->unbound_attrs);
34933493
3494− kfree(wq->rescuer);
34953494 kfree(wq);
34963495 }
34973496

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t